Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support variable log_bin #9634

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

support variable log_bin

What is changed and how it works?

cherry-pick from #9343,
and resolve some conflicts

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to be included in the release note

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2019
@zz-jason zz-jason requested a review from jackysp March 11, 2019 06:51
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I think we must update our document for this PR.

@jackysp jackysp merged commit e21d15e into pingcap:release-2.1 Mar 11, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/log_bin branch March 12, 2019 02:30
@bqwzhl20
Copy link

How to set variable log_bin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/binlog status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants