Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix false negative "full group by" check for agg in subquery #9542

Merged
merged 1 commit into from
Mar 4, 2019
Merged

planner: fix false negative "full group by" check for agg in subquery #9542

merged 1 commit into from
Mar 4, 2019

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Mar 4, 2019

What problem does this PR solve?

Fix #9518

What is changed and how it works?

Do not recursively dive into subquery in colResolverForOnlyFullGroupBy. Subquery would be checked later in its buildSelect.

Check List

Tests

  • Unit test

Code changes

N/A

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Mar 4, 2019
@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 4, 2019

/run-all-tests

@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 4, 2019

/run-integration-common-test

@eurekaka eurekaka requested review from alivxxx, zz-jason and winoros March 4, 2019 09:58
alivxxx
alivxxx reviewed Mar 4, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2019
zz-jason
zz-jason approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit d81f65f into pingcap:master Mar 4, 2019
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 4, 2019
@eurekaka eurekaka deleted the check_gby branch March 5, 2019 02:47
@eurekaka eurekaka mentioned this pull request Mar 5, 2019
Merged
eurekaka added a commit to eurekaka/tidb that referenced this pull request Mar 5, 2019
@eurekaka
planner: fix false negative "full group by" check for agg in subquery (…
24c9b99 
…pingcap#9542)
ngaut pushed a commit that referenced this pull request Mar 5, 2019
@eurekaka @ngaut
planner: fix false negative "full group by" check for agg in subquery (…
10ec9ee 
…#9542) (#9551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eurekaka @zz-jason @alivxxx