Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix false negative "full group by" check for agg in subquery (#9542) #9551

Merged
merged 1 commit into from
Mar 5, 2019
Merged

planner: fix false negative "full group by" check for agg in subquery (#9542) #9551

merged 1 commit into from
Mar 5, 2019

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Mar 5, 2019

cherry-pick #9542

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Mar 5, 2019
@eurekaka
Copy link
Contributor Author

eurekaka commented Mar 5, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

zz-jason
zz-jason reviewed Mar 5, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2019
@zz-jason zz-jason requested a review from alivxxx March 5, 2019 04:55
alivxxx
alivxxx approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 5, 2019
@ngaut ngaut merged commit 10ec9ee into pingcap:release-2.1 Mar 5, 2019
@eurekaka eurekaka deleted the 21_pick branch March 5, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@alivxxx alivxxx alivxxx approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @zz-jason @alivxxx @ngaut