Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

binlog: revert commit for variable tidb_log_bin && add send binlog strategy config #9864

Merged
merged 6 commits into from
Mar 24, 2019
Merged

binlog: revert commit for variable tidb_log_bin && add send binlog strategy config #9864

merged 6 commits into from
Mar 24, 2019

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

  1. we decide don't support change binlog online, tidb_log_bin is useless now
  2. can change send binlog's strategy

What is changed and how it works?

  1. revert two commit
  2. add new config binlog.strategy

Check List

Tests

  • Manual test (set binlog.strategy in config file, and run test)

Code changes

  • Has exported variable/fields change

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@codecov
Copy link

codecov bot commented Mar 22, 2019 •
edited
Loading

Codecov Report

Merging #9864 into master will decrease coverage by 0.0148%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             master      #9864        +/-   ##
================================================
- Coverage   67.3512%   67.3363%   -0.0149%     
================================================
  Files           383        383                
  Lines         80444      80435         -9     
================================================
- Hits          54180      54162        -18     
- Misses        21421      21425         +4     
- Partials       4843       4848         +5

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

1 similar comment
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-unit-test

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2019
jackysp
jackysp approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC merged commit d5f0d2b into pingcap:master Mar 24, 2019
@WangXiangUSTC WangXiangUSTC deleted the xiang/binlog_stragy branch March 24, 2019 10:26
@WangXiangUSTC WangXiangUSTC added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
component/binlog status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WangXiangUSTC @tiancaiamao @jackysp