fix a panic issue in parallel agg when exception is thrown (#5433) (#…

…5441) close #5356
pingcap · Jul 21, 2022 · 22ab5ec · 22ab5ec
1 parent dbffeba
commit 22ab5ec
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp b/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
@@ -156,9 +156,8 @@ void ParallelAggregatingBlockInputStream::Handler::onFinish()
 void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_ptr & exception, size_t thread_num)
 {
  parent.exceptions[thread_num] = exception;
- /// can not cancel parent inputStream or the exception might be lost
  if (!parent.executed)
- parent.processor.cancel(false);
+ parent.cancel(false);
 }