TiFlash crash when Aggregation FailPoints in createAggregateStates triggers

[yibin87]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

1. Turns on Aggregation RandomFail point
2. Prepare TPCH database, SF=10, run query_13.sql parrelly, you'll get core dump, and stack trace like this:
   

2. What did you expect to see? (Required)

TiFlash no crash.

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)

v6.2.0-alpha-nightly-20220710

[gengliqi]

I try this failpoint by using master code and find there is no crash.

The bug is very likely caused by the aggregation of non-joined data after an exception happened.

In my previous attempt, I change the code line of 201 to parent.cancel(false);.

tiflash/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp

Lines 192 to 202 in 764bd3c

	void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_ptr & exception, size_t thread_num)
	{
	parent.exceptions[thread_num] = exception;
	Int32 old_value = -1;
	parent.first_exception_index.compare_exchange_strong(old_value, static_cast<Int32>(thread_num), std::memory_order_seq_cst, std::memory_order_relaxed);
	/// can not cancel parent inputStream or the exception might be lost
	if (!parent.executed)
	/// use cancel instead of kill to avoid too many useless error message
	parent.processor.cancel(false);
	}

Then the crash doesn't happen anymore because the aggregation code of non-joined data isn't triggered. (see the code below)

tiflash/dbms/src/Interpreters/Aggregator.cpp

Lines 519 to 529 in 764bd3c

	bool Aggregator::executeOnBlock(
	const Block & block,
	AggregatedDataVariants & result,
	const FileProviderPtr & file_provider,
	ColumnRawPtrs & key_columns,
	AggregateColumns & aggregate_columns,
	Int64 & local_delta_memory,
	bool & no_more_keys)
	{
	if (isCancelled())
	return true;

However, this line of code doesn't change at present.
Why does the crash not happen? It's due to #5274.

In this PR, if an exception happens, the non-join data will not be fetched anymore so the aggregation code of them will not be triggered as well.

By the way, I think the code line of 201 still needs to be changed though it seems no harm for now.

tiflash/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp

Lines 192 to 202 in 764bd3c

	void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_ptr & exception, size_t thread_num)
	{
	parent.exceptions[thread_num] = exception;
	Int32 old_value = -1;
	parent.first_exception_index.compare_exchange_strong(old_value, static_cast<Int32>(thread_num), std::memory_order_seq_cst, std::memory_order_relaxed);
	/// can not cancel parent inputStream or the exception might be lost
	if (!parent.executed)
	/// use cancel instead of kill to avoid too many useless error message
	parent.processor.cancel(false);
	}

[gengliqi]

The bug is introduced by #3434. So it should be fixed in all versions after 5.0.