fix a panic issue in parallel agg when exception is thrown (#5433) #5438
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #5433
Signed-off-by: gengliqi gengliqiii@gmail.com
What problem does this PR solve?
Issue Number: close #5356
Problem Summary:
See #5356.
What is changed and how it works?
See #5356 (comment).
Although the panic doesn't happen by lucky coincidence due to #5274, this PR is still needed for previous branches.
It's easier to pick this PR to other branches than #5274.
The
ParallelAggregatingBlockInputStream
should be canceled when its processors meet an exception.Otherwise, the aggregation of non-joined data will still process which leads to panic like #5356 shows.
Check List
Tests
Side effects
Documentation
Release note