fix a panic issue in parallel agg when exception is thrown (#5433) (#…

…5443) close #5356
pingcap · Jul 21, 2022 · 2b4fa17 · 2b4fa17
1 parent a859794
commit 2b4fa17
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp b/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
@@ -185,10 +185,9 @@ void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_pt
     Int32 old_value = -1;
     parent.first_exception_index.compare_exchange_strong(old_value, static_cast<Int32>(thread_num), std::memory_order_seq_cst, std::memory_order_relaxed);
 
-    /// can not cancel parent inputStream or the exception might be lost
     if (!parent.executed)
         /// kill the processor so ExchangeReceiver will be closed
-        parent.processor.cancel(true);
+        parent.cancel(true);
 }