fix: fix build issue ‘maybe_unused’ attribute ignored on centos ser…

…ver (#4700) close #4701
pingcap · Apr 18, 2022 · afdd2e0 · afdd2e0
1 parent cf8ab95
commit afdd2e0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/dbms/src/Common/CPUAffinityManager.h b/dbms/src/Common/CPUAffinityManager.h
@@ -14,6 +14,8 @@
 
 #pragma once
 
+#include <common/defines.h>
+
 #include <string>
 #include <thread>
 #include <unordered_map>
@@ -115,8 +117,9 @@ class CPUAffinityManager
 #endif
 
     // unused except Linux
-    [[maybe_unused]] int query_cpu_percent;
-    [[maybe_unused]] int cpu_cores;
+    MAYBE_UNUSED_MEMBER int query_cpu_percent;
+    MAYBE_UNUSED_MEMBER int cpu_cores;
+
     std::vector<std::string> query_threads;
     Poco::Logger * log;
 

diff --git a/libs/libcommon/include/common/defines.h b/libs/libcommon/include/common/defines.h
@@ -199,3 +199,9 @@ static ALWAYS_INLINE inline void TIFLASH_NO_OPTIMIZE(T && var)
 #define TIFLASH_DUMMY_FUNCTION_DEFINITION
 #define tiflash_compiler_builtin_memcpy __builtin_memcpy
 #endif
+
+#ifdef __clang__
+#define MAYBE_UNUSED_MEMBER [[maybe_unused]]
+#else
+#define MAYBE_UNUSED_MEMBER
+#endif