Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix build issue ‘maybe_unused’ attribute ignored on centos server #4700

Merged
merged 1 commit into from
Apr 18, 2022
Merged

fix: fix build issue ‘maybe_unused’ attribute ignored on centos server #4700

merged 1 commit into from
Apr 18, 2022

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Apr 18, 2022 •
edited
Loading

Issue Number: close #4701

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Apr 18, 2022
@LittleFall
Copy link
Contributor Author

/run-check-issue-triage-complete

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2022
@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 18, 2022
@LittleFall
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2022
@LittleFall
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@LittleFall: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 75c2bd1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 18, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 18, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
dbms/src/Common/CPUAffinityManager.h              1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
libs/libcommon/include/common/defines.h           2                 0   100.00%           2                 0   100.00%           8                 0   100.00%           0                 0         -
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                             3                 0   100.00%           3                 0   100.00%           9                 0   100.00%           0                 0         -

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17131      9491             44.60%    192836  96249        50.09%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit afdd2e0 into pingcap:master Apr 18, 2022
@LittleFall LittleFall deleted the fix/server-build branch April 18, 2022 14:15
@JaySon-Huang JaySon-Huang mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywqzzy ywqzzy ywqzzy approved these changes

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@solotzg solotzg Awaiting requested review from solotzg

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server build failed.
6 participants
@LittleFall @ti-chi-bot @sre-bot @fuzhe1989 @solotzg @ywqzzy