Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration profiles.default.background_pool_size not take effect. #4684

Closed
JinheLin opened this issue Apr 16, 2022 · 2 comments · Fixed by #4686
Closed

Configuration profiles.default.background_pool_size not take effect. #4684

JinheLin opened this issue Apr 16, 2022 · 2 comments · Fixed by #4686
Assignees
@JinheLin
Labels
affects-5.4 affects-6.0 severity/major type/bug The issue is confirmed as a bug.

Comments

@JinheLin
Copy link
Contributor

Bug Report

1. Minimal reproduce step (Required)

Set configuration profiles.default.background_pool_size: 8.

2. What did you expect to see? (Required)

Create BackgroundProcessingPool with 8 threads.

3. What did you see instead (Required)

[2022/04/15 19:53:55.826 +08:00] [INFO] [<unknown>] ["BackgroundProcessingPool:Create BackgroundProcessingPool with 16 threads"] [thread_id=1]

4. What is your TiFlash version? (Required)

master
@JinheLin JinheLin added type/bug The issue is confirmed as a bug. severity/major labels Apr 16, 2022
@JinheLin JinheLin self-assigned this Apr 16, 2022
@JinheLin JinheLin mentioned this issue Apr 16, 2022
Merged
12 tasks
@flowbehappy
Copy link
Contributor

So background_pool_size is determined by the actual core number?

@JinheLin
Copy link
Contributor Author

So background_pool_size is determined by the actual core number?

It is currently hard-coded.

#define DBMS_DEFAULT_BACKGROUND_POOL_SIZE 16

ti-chi-bot pushed a commit that referenced this issue Apr 18, 2022
@JinheLin
Fix background_pool_size not take effect and BackgroundProcessingPool…
cf8ab95 
…::getThreadIds may misses some thread_ids. (#4686)

close #4684, ref #4685
This was referenced Apr 18, 2022
Merged
Closed
ti-chi-bot added a commit that referenced this issue Apr 27, 2022
@ti-chi-bot
Fix background_pool_size not take effect and BackgroundProcessingPool…
0ad7fe4 
…::getThreadIds may misses some thread_ids. (#4686) (#4696)

close #4684, ref #4685
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JinheLin JinheLin

Labels
affects-5.4 affects-6.0 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
3 participants
@flowbehappy @JinheLin @ti-chi-bot