Fix background_pool_size not take effect and BackgroundProcessingPool::getThreadIds may misses some thread_ids. (#4686) #4697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #4686
What problem does this PR solve?
Issue Number: close #4684 #4685
Problem Summary:
Context::setDefaultProfiles
should be called beforeContext::initializeRateLimiter
. BecauseContext::initializeRateLimiter
callsContext::getBackgroundPool
andContext::getBlockableBackgroundPool
inside to get background thread ids.BackgroundProcessingPool::getThreadIds
andBackgroundProcessingPool::addThreadId
are executing concurrently.BackgroundProcessingPool::getThreadIds
may be called before all background threads executing ``BackgroundProcessingPool::addThreadId` completely.What is changed and how it works?
Context
.absl::BlockingCounter
to count all background threads executingBackgroundProcessingPool::addThreadId
completely.Check List
Tests
profiles.default.background_pool_size: 8
.Side effects
Documentation
Release note