*: fix gettid compile error #4704

ywqzzy · 2022-04-19T07:20:08Z

What problem does this PR solve?

Issue Number: close #4703

Problem Summary:
The function gettid declaration is conflict with gettid in unistd_ext.h.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

None

ti-chi-bot · 2022-04-19T07:20:09Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

JinheLin
Lloyd-Pottiger

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

ywqzzy · 2022-04-19T07:20:45Z

/run-all-tests

JinheLin · 2022-04-19T07:34:18Z

/merge

ti-chi-bot · 2022-04-19T07:34:19Z

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-19T07:34:20Z

This pull request has been accepted and is ready to merge.

Commit hash: 687c545

jiaqizho · 2022-04-19T10:04:30Z

/hold

jiaqizho · 2022-04-19T10:05:27Z

dbms/src/Storages/BackgroundProcessingPool.cpp

@@ -29,12 +29,12 @@
 #ifdef __linux__
 #include <sys/syscall.h>
 #include <unistd.h>
-inline static pid_t gettid()
+inline static pid_t getTid()
 {
    return syscall(SYS_gettid);
 }
 #elif


This is not correct.

BackgroundProcessingPool.cpp:36:6: error: expected value in expression #elif ^ BackgroundProcessingPool.cpp:153:21: error: use of undeclared identifier 'gettid' addThreadId(gettid());

#elif change to #else

sre-bot · 2022-04-19T10:13:18Z

Coverage for changed files

Filename                                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/BackgroundProcessingPool.cpp          88                31    64.77%          10                 1    90.00%         180                36    80.00%          54                22    59.26%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              88                31    64.77%          10                 1    90.00%         180                36    80.00%          54                22    59.26%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17131      9491             44.60%    192836  96238        50.09%

full coverage report (for internal network access only)

jiaqizho · 2022-04-19T11:04:39Z

/unhold

ywqzzy · 2022-04-19T11:07:05Z

/merge

ti-chi-bot · 2022-04-19T11:07:06Z

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-04-19T11:07:07Z

This pull request has been accepted and is ready to merge.

Commit hash: 6ef762d

sre-bot · 2022-04-19T11:41:21Z

Coverage for changed files

Filename                                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/BackgroundProcessingPool.cpp          88                31    64.77%          10                 1    90.00%         180                36    80.00%          54                22    59.26%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              88                31    64.77%          10                 1    90.00%         180                36    80.00%          54                22    59.26%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17131      9491             44.60%    192836  96246        50.09%

full coverage report (for internal network access only)

ywqzzy · 2022-04-19T12:07:48Z

/hold

ywqzzy · 2022-04-19T12:44:28Z

/unhold

ywqzzy · 2022-04-19T12:45:38Z

/run-all-tests

sre-bot · 2022-04-19T13:01:04Z

Coverage for changed files

Filename                                                                                                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
/home/jenkins/agent/workspace/tiflash-build-common/tiflash/dbms/src/Storages/BackgroundProcessingPool.cpp          88                31    64.77%          10                 1    90.00%         180                36    80.00%          54                22    59.26%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                              88                31    64.77%          10                 1    90.00%         180                36    80.00%          54                22    59.26%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
17132      9492             44.59%    192847  96250        50.09%

full coverage report (for internal network access only)

update.

687c545

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 19, 2022

ywqzzy requested review from JinheLin and Lloyd-Pottiger April 19, 2022 07:20

Lloyd-Pottiger approved these changes Apr 19, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 19, 2022

JinheLin approved these changes Apr 19, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 19, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2022

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2022

jiaqizho reviewed Apr 19, 2022

View reviewed changes

ywqzzy added 2 commits April 19, 2022 18:14

update.

ed3ac24

Merge branch 'master' into fix_gettid_compile_error

6ef762d

ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2022

ywqzzy requested a review from jiaqizho April 19, 2022 10:53

jiaqizho approved these changes Apr 19, 2022

View reviewed changes

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 19, 2022

Merge branch 'master' into fix_gettid_compile_error

1508ccc

ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2022

ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2022

ti-chi-bot merged commit 636fcd2 into pingcap:master Apr 19, 2022

Lloyd-Pottiger mentioned this pull request Apr 20, 2022

Fix background_pool_size not take effect and BackgroundProcessingPool::getThreadIds may misses some thread_ids. (#4686) #4697

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: fix gettid compile error #4704

*: fix gettid compile error #4704

ywqzzy commented Apr 19, 2022 •

edited

Loading

ti-chi-bot commented Apr 19, 2022 •

edited

Loading

ywqzzy commented Apr 19, 2022

JinheLin commented Apr 19, 2022

ti-chi-bot commented Apr 19, 2022

ti-chi-bot commented Apr 19, 2022

jiaqizho commented Apr 19, 2022

jiaqizho Apr 19, 2022

jiaqizho Apr 19, 2022

sre-bot commented Apr 19, 2022

jiaqizho commented Apr 19, 2022

ywqzzy commented Apr 19, 2022

ti-chi-bot commented Apr 19, 2022

ti-chi-bot commented Apr 19, 2022

sre-bot commented Apr 19, 2022

ywqzzy commented Apr 19, 2022

ywqzzy commented Apr 19, 2022

ywqzzy commented Apr 19, 2022

sre-bot commented Apr 19, 2022

*: fix gettid compile error #4704

*: fix gettid compile error #4704

Conversation

ywqzzy commented Apr 19, 2022 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Release note

ti-chi-bot commented Apr 19, 2022 • edited Loading

ywqzzy commented Apr 19, 2022

JinheLin commented Apr 19, 2022

ti-chi-bot commented Apr 19, 2022

ti-chi-bot commented Apr 19, 2022

jiaqizho commented Apr 19, 2022

jiaqizho Apr 19, 2022

Choose a reason for hiding this comment

jiaqizho Apr 19, 2022

Choose a reason for hiding this comment

sre-bot commented Apr 19, 2022

Coverage for changed files

Coverage summary

jiaqizho commented Apr 19, 2022

ywqzzy commented Apr 19, 2022

ti-chi-bot commented Apr 19, 2022

ti-chi-bot commented Apr 19, 2022

sre-bot commented Apr 19, 2022

Coverage for changed files

Coverage summary

ywqzzy commented Apr 19, 2022

ywqzzy commented Apr 19, 2022

ywqzzy commented Apr 19, 2022

sre-bot commented Apr 19, 2022

Coverage for changed files

Coverage summary

ywqzzy commented Apr 19, 2022 •

edited

Loading

ti-chi-bot commented Apr 19, 2022 •

edited

Loading