Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential data corruption with small frame size in DTFile #4778

Closed
SchrodingerZhu opened this issue Apr 27, 2022 · 0 comments · Fixed by #4777
Closed

Potential data corruption with small frame size in DTFile #4778

SchrodingerZhu opened this issue Apr 27, 2022 · 0 comments · Fixed by #4777
Assignees
@SchrodingerZhu
Labels
affects-5.4 affects-6.0 severity/major type/bug The issue is confirmed as a bug.

Comments

@SchrodingerZhu
Copy link
Contributor

SchrodingerZhu commented Apr 27, 2022 •
edited
Loading

Bug Report

tiflash/dbms/src/Storages/DeltaMerge/File/DMFile.cpp

Line 582 in c6740e5

auto frame_count = size / this->configuration->getChecksumFrameLength()

This line does not count frame header length in file.
This makes the idx reading progress fail if there are multiple idx frames. (exceptions of checksum error)
@SchrodingerZhu SchrodingerZhu added the type/bug The issue is confirmed as a bug. label Apr 27, 2022
@SchrodingerZhu SchrodingerZhu self-assigned this Apr 27, 2022
@SchrodingerZhu SchrodingerZhu mentioned this issue Apr 27, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Apr 28, 2022
@SchrodingerZhu
fix: ut and more idx error (#4777)
e845908 
close #4778
This was referenced Apr 28, 2022
Closed
Merged
ti-chi-bot added a commit that referenced this issue Apr 28, 2022
@ti-chi-bot
fix: ut and more idx error (#4777) (#4790)
4eb12de 
close #4778
@JaySon-Huang JaySon-Huang mentioned this issue Apr 28, 2022
Closed
@guo-shaoge guo-shaoge mentioned this issue May 7, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SchrodingerZhu SchrodingerZhu

Labels
affects-5.4 affects-6.0 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ut and more idx error pingcap/tiflash
3 participants
@flowbehappy @SchrodingerZhu @ti-chi-bot