Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ut and more idx error #4777

Merged
merged 3 commits into from
Apr 28, 2022
Merged

fix: ut and more idx error #4777

merged 3 commits into from
Apr 28, 2022

Conversation

SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Apr 27, 2022

Signed-off-by: SchrodingerZhu i@zhuyi.fan

What problem does this PR solve?

Issue Number: close #4778

This PR fixes the problem mentioned in #4778 and add variant frame lengths to cover the cases.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

fix potential data corruption for large indices

Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 27, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hehechen
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 and removed do-not-merge/needs-linked-issue labels Apr 27, 2022
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 27, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 27, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 27, 2022
@SchrodingerZhu
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 27, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Server/DTTool/DTToolMigrate.cpp             223                80    64.13%          11                 1    90.91%         283               154    45.58%         132                76    42.42%
Server/tests/gtest_dttool.cpp               422                53    87.44%           7                 0   100.00%         223                 6    97.31%         150                64    57.33%
Storages/DeltaMerge/File/DMFile.cpp         341               109    68.04%          46                 2    95.65%         691               122    82.34%         204                64    68.63%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       986               242    75.46%          64                 3    95.31%        1197               282    76.44%         486               204    58.02%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18056      10153            43.77%    200047  100965       49.53%

full coverage report (for internal network access only)

@SchrodingerZhu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@SchrodingerZhu: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2b3417e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 28, 2022
@ti-chi-bot
Copy link
Member

@SchrodingerZhu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 28, 2022

Coverage for changed files

Filename                                Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Server/DTTool/DTToolMigrate.cpp             223                80    64.13%          11                 1    90.91%         283               154    45.58%         132                76    42.42%
Server/tests/gtest_dttool.cpp               422                53    87.44%           7                 0   100.00%         223                 6    97.31%         150                64    57.33%
Storages/DeltaMerge/File/DMFile.cpp         341               109    68.04%          46                 2    95.65%         691               122    82.34%         204                64    68.63%
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       986               242    75.46%          64                 3    95.31%        1197               282    76.44%         486               204    58.02%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18056      10152            43.77%    200047  100944       49.54%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit e845908 into master Apr 28, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2022
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4789.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2022
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4790.

ti-chi-bot added a commit that referenced this pull request Apr 28, 2022
@ngaut ngaut deleted the fix/wrong-idx-calculation branch June 16, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.0 Type: Need cherry pick to release-6.0 release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential data corruption with small frame size in DTFile
5 participants