Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug that mpp_fail test cost too much time / Fix test clustered index test cases (#1591) #1600

Merged

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Mar 20, 2021

cherry-pick #1591 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1600

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/1600:release-5.0-891466e91f1d

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

After pingcap/tidb#23056, fullstack test mpp_fail takes too much time(more than 10 minutes), which is expected.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

The root cause is after pingcap/tidb#23056, TiDB will send kill command to kill all the mpp tasks for a specified query, and currently implementation of cancelling a mpp task will call writeErrToAllTunnel to write error message to other mpp tasks, since all the mpp tasks are canceled at the same time, writeErrToAllTunnel might hangs for a little time(write error message until tunnel is timeout), so the test execution time is much more than expected. In this pr, when canceling a mpp task, it just call closeAllTunnel to close the tunnel, which only write error message to other mpp task if the tunnel is already connected.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@JaySon-Huang
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang JaySon-Huang merged commit 26d996c into pingcap:release-5.0 Mar 20, 2021
@JaySon-Huang JaySon-Huang deleted the release-5.0-891466e91f1d branch March 20, 2021 04:36
@JaySon-Huang JaySon-Huang changed the title fix bug that mpp_fail test cost too much time (#1591) fix bug that mpp_fail test cost too much time / Fix test clustered index test cases (#1591) Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants