fix bug that mpp_fail test cost too much time / Fix test clustered index test cases (#1591) #1600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1591 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/1600
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
After pingcap/tidb#23056, fullstack test
mpp_fail
takes too much time(more than 10 minutes), which is expected.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause is after pingcap/tidb#23056, TiDB will send
kill
command to kill all the mpp tasks for a specified query, and currently implementation of cancelling a mpp task will callwriteErrToAllTunnel
to write error message to other mpp tasks, since all the mpp tasks are canceled at the same time,writeErrToAllTunnel
might hangs for a little time(write error message until tunnel is timeout), so the test execution time is much more than expected. In this pr, when canceling a mpp task, it just callcloseAllTunnel
to close the tunnel, which only write error message to other mpp task if the tunnel is already connected.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note