fix bug that mpp_fail test cost too much time / Fix test clustered index test cases #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanfei1991
approved these changes
Mar 19, 2021
|
Will this PR fix the problem that Related to #1586 (comment) |
|
/run-all-tests |
|
/run-all-tests |
|
Mark that this PR also fixes the test cases of clustered index. pingcap/tidb#23270 |
JaySon-Huang
added
the
needs-cherry-pick-release-5.0
|
cherry pick to release-5.0 in PR #1600 |
JaySon-Huang
pushed a commit
that referenced
this pull request
Mar 20, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: xufei <xufei@pingcap.com>
JaySon-Huang
changed the title
Yes, but this pr still have a small chances that TiFlash server will crash when meet some mpp errors, #1577 fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
After pingcap/tidb#23056, fullstack test
mpp_failtakes too much time(more than 10 minutes), which is expected.What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause is after pingcap/tidb#23056, TiDB will send
killcommand to kill all the mpp tasks for a specified query, and currently implementation of cancelling a mpp task will callwriteErrToAllTunnelto write error message to other mpp tasks, since all the mpp tasks are canceled at the same time,writeErrToAllTunnelmight hangs for a little time(write error message until tunnel is timeout), so the test execution time is much more than expected. In this pr, when canceling a mpp task, it just callcloseAllTunnelto close the tunnel, which only write error message to other mpp task if the tunnel is already connected.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note