Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up test cases for clustered index (#1599) #1603

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Mar 20, 2021

cherry-pick #1599 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tics repo:
git pr https://github.com/pingcap/tics/pull/1603

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tics.git pr/1603:release-5.0-f20dfc6a3b8f

What problem does this PR solve?

Tidy up test cases after #1591

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added CHERRY-PICK cherry pick status/LGT1 Indicates that a PR has LGTM 1. type/testing Issue or PR for testing labels Mar 20, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Mar 20, 2021
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@windtalker windtalker added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2021
@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 1582

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot
Copy link
Collaborator Author

@ti-srebot merge failed.

@JaySon-Huang
Copy link
Contributor

/merge

@ti-srebot
Copy link
Collaborator Author

Your auto merge job has been accepted, waiting for:

  • 1598

@ti-srebot
Copy link
Collaborator Author

/run-all-tests

@ti-srebot ti-srebot merged commit f6927aa into pingcap:release-5.0 Mar 22, 2021
@JaySon-Huang JaySon-Huang deleted the release-5.0-f20dfc6a3b8f branch March 22, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/testing Issue or PR for testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants