Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[POC]New page storage #3197

Closed
wants to merge 8 commits into from
Closed

[POC]New page storage #3197

wants to merge 8 commits into from

Conversation

jiaqizho
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

Want to know its write performance? just try it with:

make new_page_stress_testing -j && ./dbms/src/Storages/Page/NP/new_page_stress_testing

What is changed and how it works?

Proposal:

  • remove GC
  • redesign meta format
  • faster in WR

What's Changed:

There are still many details to confirm.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note 

None

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 12, 2021
jiaqizho
jiaqizho commented Nov 9, 2021
View reviewed changes
dbms/src/Storages/Page/V3/tests/stress_test_new_ps.cpp
}


int main(int argc, char ** argv)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no update yet

@ti-chi-bot
Copy link
Member

@jiaqizho: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2021
@jiaqizho jiaqizho mentioned this pull request Nov 22, 2021
Merged
@JaySon-Huang
Copy link
Contributor

Going to close it since we have a more specified plan for improving in #3594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiaqizho @ti-chi-bot @JaySon-Huang