-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add space_map
into PageStorage V3
#3493
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
space_map
into PageStorage V3space_map
into PageStorage V3
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Refactor SpaceMap interface
space_map
into PageStorage V3space_map
into PageStorage V3
/run-all-tests |
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/258/cobertura/ lines: 37.6% (44765 out of 119179) |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/292/cobertura/ lines: 41.0% (45541 out of 111197) |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out the changes in https://github.com/jiaqizho/tics/pull/5 and resolve the below comments.
The line coverage for files under spacemap is only 67%. I hope it can be greater than 80% before merging. https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/292/cobertura/dbms_src_Storages_Page_V3_spacemap/
SpaceMap interface cleanup
Co-authored-by: JaySon <jayson.hjs@gmail.com>
/run-unit-test |
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/298/cobertura/ lines: 41.1% (45729 out of 111243) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: JaySon <jayson.hjs@gmail.com>
/merge |
@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 00bf672
|
Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/299/cobertura/ lines: 41.0% (45652 out of 111243) |
What problem does this PR solve?
Issue Number:
Problem Summary:
What is changed and how it works?
Proposal:
What's Changed:
space_map
support free locationmark
method with a no nearbyblock
.block
.cmake
asPageStorage V3
beginning.gtests
forspace_map
.Similar scope mergers have not yet been done. For this, there will create a new
PR
in the future.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note