Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable cache small column by default #4225

Merged
merged 3 commits into from
Mar 15, 2022
Merged

disable cache small column by default #4225

merged 3 commits into from
Mar 15, 2022

Conversation

hehechen
Copy link
Contributor

@hehechen hehechen commented Mar 11, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4223

Problem Summary:
DELTA_CACHE_SIZE is too high and may use too much memory, disable cache small column.

What is changed and how it works?

Disable cache small column.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    CH-benCHmark:
    image

Before modify:
image

After modify:
image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2022
@flowbehappy flowbehappy self-requested a review March 11, 2022 06:22
@hehechen
Copy link
Contributor Author

/run-build-x86 comment=true

@SchrodingerZhu
Copy link
Contributor

/build

1 similar comment
@SchrodingerZhu
Copy link
Contributor

/build

@SchrodingerZhu
Copy link
Contributor

/run-all-tests

@SchrodingerZhu
Copy link
Contributor

/run-unit-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2022
@hehechen
Copy link
Contributor Author

/build

@hehechen
Copy link
Contributor Author

/run-unit-tests

@SchrodingerZhu
Copy link
Contributor

/run-integration-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 11, 2022

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Interpreters/Settings.h                                            1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/DeltaMerge/DMContext.h                                    4                 0   100.00%           4                 0   100.00%           7                 0   100.00%           0                 0         -
Storages/DeltaMerge/Delta/ColumnFileFlushTask.cpp                 41                 4    90.24%           3                 0   100.00%          65                 5    92.31%          28                 6    78.57%
Storages/DeltaMerge/tests/gtest_dm_delta_merge_store.cpp        6137              1649    73.13%          38                 1    97.37%        2782                96    96.55%        2048               908    55.66%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                           6183              1653    73.27%          46                 1    97.83%        2855               101    96.46%        2076               914    55.97%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16779      9446             43.70%    189050  95726        49.36%

full coverage report (for internal network access only)

@hehechen
disable cache small column
ff80cdc 
Signed-off-by: hehechen <awd123456sss@gmail.com>
@hehechen
Copy link
Contributor Author

/run-unit-tests

lidezhu
lidezhu approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 15, 2022
@flowbehappy flowbehappy mentioned this pull request Mar 15, 2022
Closed
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed do-not-merge/needs-triage-completed labels Mar 15, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

Filename                                 Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Delta/ColumnFileFlushTask.cpp                 32                 2    93.75%           3                 0   100.00%          59                 5    91.53%          20                 2    90.00%
tests/gtest_dm_delta_merge_store.cpp        6008              1604    73.30%          37                 1    97.30%        2710                93    96.57%        2002               886    55.74%
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                       6040              1606    73.41%          40                 1    97.50%        2769                98    96.46%        2022               888    56.08%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16778      9449             43.68%    188972  95743        49.33%

full coverage report (for internal network access only)

@dianqihanwangzi
Copy link

/run-build-release

@hehechen
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ff80cdc

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2022
@ti-chi-bot
Copy link
Member

@hehechen: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 15, 2022

Coverage for changed files

Filename                                                     Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Mpp/MPPTask.cpp                                            395               395     0.00%          20                20     0.00%         328               328     0.00%         176               176     0.00%
Flash/Mpp/MPPTask.h                                                3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
Flash/Mpp/MPPTaskManager.cpp                                      97                96     1.03%          11                10     9.09%         173               172     0.58%          70                70     0.00%
Flash/Mpp/MPPTaskManager.h                                         1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Flash/Mpp/MPPTunnel.cpp                                          175               175     0.00%          16                16     0.00%         233               233     0.00%          90                90     0.00%
Flash/Mpp/MinTSOScheduler.cpp                                    228               213     6.58%           7                 6    14.29%         145               135     6.90%         132               127     3.79%
Flash/Mpp/MinTSOScheduler.h                                        4                 1    75.00%           2                 0   100.00%           4                 0   100.00%           4                 3    25.00%
Interpreters/Settings.h                                            1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/DeltaMerge/Delta/ColumnFileFlushTask.cpp                 32                 2    93.75%           3                 0   100.00%          59                 5    91.53%          20                 2    90.00%
Storages/DeltaMerge/tests/gtest_dm_delta_merge_store.cpp        6008              1604    73.30%          37                 1    97.30%        2712                93    96.57%        2002               886    55.74%
Storages/StorageDeltaMerge.cpp                                   669               360    46.19%          56                29    48.21%        1292               762    41.02%         378               259    31.48%
Storages/Transaction/TMTContext.cpp                               53                37    30.19%          34                19    44.12%         149               102    31.54%          12                11     8.33%
Storages/Transaction/TMTContext.h                                  4                 3    25.00%           4                 3    25.00%           4                 3    25.00%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                           7670              2889    62.33%         195               107    45.13%        5104              1836    64.03%        2884              1624    43.69%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16923      9504             43.84%    190671  96488        49.40%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 420c03d into pingcap:master Mar 15, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 15, 2022
@hehechen @ti-chi-bot
This is an automated cherry-pick of pingcap#4225
f1aea57 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4275.

@JaySon-Huang JaySon-Huang deleted the delta_cache branch March 15, 2022 05:28
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Mar 17, 2022
@hehechen @JaySon-Huang
disable cache small column by default (pingcap#4225)
82b235d 
close pingcap#4223
hehechen pushed a commit that referenced this pull request Apr 24, 2022
@ti-chi-bot
disable cache small column by default (#4225) (#4275)
4af7151 
* This is an automated cherry-pick of #4225

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* disable cache small column

Signed-off-by: chentongli <chentongli@pingcap.com>

* Update gtest_dm_delta_merge_store.cpp

* Update gtest_dm_delta_merge_store.cpp

* fix ut fail

Signed-off-by: hehechen <awd123456sss@gmail.com>
hehechen added a commit to hehechen/tics that referenced this pull request Apr 25, 2022
@hehechen
This is an automated cherry-pick of pingcap#4225
963e1b2 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
hehechen added a commit to hehechen/tics that referenced this pull request Apr 25, 2022
@hehechen
This is an automated cherry-pick of pingcap#4225
c8258fc 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@hehechen hehechen mentioned this pull request Apr 25, 2022
Merged
12 tasks
hehechen added a commit that referenced this pull request Apr 25, 2022
@hehechen
disable cache small column (#4753)
81e3908 
* This is an automated cherry-pick of #4225

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* disable cache small column

Signed-off-by: chentongli <chentongli@pingcap.com>

* Update gtest_dm_delta_merge_store.cpp

* Update gtest_dm_delta_merge_store.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DELTA_CACHE_SIZE is too high which rise the possibility of OOM
7 participants
@hehechen @ti-chi-bot @SchrodingerZhu @sre-bot @dianqihanwangzi @flowbehappy @lidezhu