Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable cache small column by default (#4225) #4275

Merged
merged 11 commits into from
Apr 24, 2022
Merged

disable cache small column by default (#4225) #4275

merged 11 commits into from
Apr 24, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4225

What problem does this PR solve?

Issue Number: close #4223

Problem Summary:
DELTA_CACHE_SIZE is too high and may use too much memory, disable cache small column.

What is changed and how it works?

Disable cache small column.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    CH-benCHmark:
    image

Before modify:
image

After modify:
image

  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@hehechen @ti-chi-bot
This is an automated cherry-pick of pingcap#4225
f1aea57 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Mar 15, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • flowbehappy
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Mar 15, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 15, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Mar 15, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 21, 2022
@JaySon-Huang JaySon-Huang added this to the v5.4.1 milestone Apr 21, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2022
@JaySon-Huang JaySon-Huang force-pushed the cherry-pick-4225-to-release-5.4 branch from 23a4643 to 7a33476 Compare April 21, 2022 12:50
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 21, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JaySon-Huang JaySon-Huang force-pushed the cherry-pick-4225-to-release-5.4 branch from 7a33476 to 0236c89 Compare April 21, 2022 14:54
disable cache small column
eeb334e 
Signed-off-by: chentongli <chentongli@pingcap.com>
@JaySon-Huang JaySon-Huang force-pushed the cherry-pick-4225-to-release-5.4 branch from 0236c89 to eeb334e Compare April 22, 2022 01:37
@hehechen
Copy link
Contributor

/run-all-tests

@hehechen
Copy link
Contributor

/run-all-tests

@hehechen
Copy link
Contributor

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

lines: 43.3% (49861 out of 115158)
branches: 6.5% (81553 out of 1264119)

@hehechen hehechen requested review from flowbehappy and JaySon-Huang and removed request for flowbehappy April 22, 2022 08:46
@hehechen hehechen requested a review from lidezhu April 22, 2022 08:48
lidezhu
lidezhu approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 22, 2022
@hehechen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 25df5c6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 22, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

lines: 43.3% (49893 out of 115245)
branches: 6.5% (81634 out of 1264629)

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 22, 2022

lines: 43.3% (49920 out of 115269)
branches: 6.5% (81655 out of 1264692)

@hehechen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

fix ut fail
28cc7dd 
Signed-off-by: chentongli <chentongli@pingcap.com>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@hehechen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@hehechen: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 28cc7dd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Apr 24, 2022

lines: 43.3% (49925 out of 115289)
branches: 6.5% (81672 out of 1264825)

@hehechen
Copy link
Contributor

/run-cla

@hehechen hehechen merged commit 4af7151 into pingcap:release-5.4 Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees

@hehechen hehechen

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.1
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-chi-bot @CLAassistant @hehechen @sre-bot @flowbehappy @lidezhu @JaySon-Huang @VelocityLight