-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BlobStore: remove the old_ids, not need recycle the blob id. #4247
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
/merge |
@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
@jiaqizho: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jiaqizho you need to refine some tests in |
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
/merge |
@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: c57ac60
|
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
@jiaqizho: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
…#4247) ref pingcap#3594 Signed-off-by: ywqzzy <592838129@qq.com>
Signed-off-by: ywqzzy <592838129@qq.com> update. Signed-off-by: ywqzzy <592838129@qq.com> update. Signed-off-by: ywqzzy <592838129@qq.com> Split write and ingest throughput (pingcap#4245) close pingcap#4243 Signed-off-by: ywqzzy <592838129@qq.com> fix the problem that expired data was not recycled timely due to slow gc speed (pingcap#4224) close pingcap#4146 Signed-off-by: ywqzzy <592838129@qq.com> PageStorage: Fix some bugs (pingcap#4212) ref pingcap#3594 Signed-off-by: ywqzzy <592838129@qq.com> Make test of CreateTables using affected opts (pingcap#4239) close pingcap#4235 Signed-off-by: ywqzzy <592838129@qq.com> BlobStore: remove the old_ids, not need recycle the blob id. (pingcap#4247) ref pingcap#3594 Signed-off-by: ywqzzy <592838129@qq.com> support `PartitionTableScan` in TiFlash (pingcap#3876) close pingcap#3873 Signed-off-by: ywqzzy <592838129@qq.com> update. Signed-off-by: ywqzzy <592838129@qq.com> update. Signed-off-by: ywqzzy <592838129@qq.com> support last_day and dayofmonth pushdown to tiflash (pingcap#4183) close pingcap#4149 Signed-off-by: ywqzzy <592838129@qq.com>
What problem does this PR solve?
Issue Number: ref #3594
Problem Summary: Reusing the old blob file id that was removed is not readable for tracing bug by log files.
What is changed and how it works?
Remove the mechanism of reusing the old blob file id.
Check List
Tests
Side effects
Documentation
Release note