Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlobStore: remove the old_ids, not need recycle the blob id. #4247

Merged
merged 4 commits into from
Mar 14, 2022
Merged

BlobStore: remove the old_ids, not need recycle the blob id. #4247

merged 4 commits into from
Mar 14, 2022

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Mar 14, 2022

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary: Reusing the old blob file id that was removed is not readable for tracing bug by log files.

What is changed and how it works?

Remove the mechanism of reusing the old blob file id.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. labels Mar 14, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 14, 2022
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
@jiaqizho jiaqizho changed the title BlobStore: remove the roll_ids, not need recycle the blob id. BlobStore: remove the old_ids, not need recycle the blob id. Mar 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2022
@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@jiaqizho: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@jiaqizho jiaqizho requested a review from CalvinNeo March 14, 2022 07:00
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2022
@JaySon-Huang
Copy link
Contributor

Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
@jiaqizho
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 14, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
BlobStore.cpp                      344               108    68.60%          38                 3    92.11%         747               201    73.09%         216                84    61.11%
BlobStore.h                          7                 1    85.71%           7                 1    85.71%          25                10    60.00%           0                 0         -
tests/gtest_blob_store.cpp        3457               576    83.34%          17                 0   100.00%         671                 0   100.00%        1072               506    52.80%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             3808               685    82.01%          62                 4    93.55%        1443               211    85.38%        1288               590    54.19%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16776      9447             43.69%    188894  95744        49.31%

full coverage report (for internal network access only)

@jiaqizho
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c57ac60

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 14, 2022

Coverage for changed files

Filename                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Mpp/MPPTunnel.h                                     8                 8     0.00%           8                 8     0.00%          14                14     0.00%           0                 0         -
Interpreters/Settings.h                                   1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/Page/V3/BlobStore.cpp                          344               108    68.60%          38                 3    92.11%         748               201    73.13%         216                84    61.11%
Storages/Page/V3/BlobStore.h                              7                 1    85.71%           7                 1    85.71%          25                10    60.00%           0                 0         -
Storages/Page/V3/PageDirectory.cpp                      441                68    84.58%          30                 3    90.00%         986               195    80.22%         364                84    76.92%
Storages/Page/V3/PageDirectory.h                         24                 6    75.00%          24                 6    75.00%         101                21    79.21%           0                 0         -
Storages/Page/V3/PageDirectoryFactory.cpp                36                 8    77.78%           4                 0   100.00%         105                20    80.95%          42                 9    78.57%
Storages/Page/V3/PageEntriesEdit.h                       54                10    81.48%          39                 8    79.49%         157                42    73.25%          14                 6    57.14%
Storages/Page/V3/WAL/WALReader.cpp                       71                 9    87.32%           9                 0   100.00%         173                13    92.49%          54                12    77.78%
Storages/Page/V3/WAL/serialize.cpp                       47                11    76.60%          15                 1    93.33%         190                41    78.42%          52                16    69.23%
Storages/Page/V3/WALStore.cpp                            69                39    43.48%           8                 1    87.50%         119                42    64.71%          32                19    40.62%
Storages/Page/V3/tests/entries_helper.h                  65                36    44.62%          10                 3    70.00%         238               111    53.36%          32                21    34.38%
Storages/Page/V3/tests/gtest_blob_store.cpp            3457               576    83.34%          17                 0   100.00%         671                 0   100.00%        1072               506    52.80%
Storages/Page/V3/tests/gtest_page_directory.cpp        8494              1499    82.35%          46                 0   100.00%        1549                 7    99.55%        2672              1352    49.40%
Storages/Page/V3/tests/gtest_page_storage.cpp          2599               952    63.37%          31                 7    77.42%         704               154    78.12%         832               498    40.14%
Storages/Page/V3/tests/gtest_wal_store.cpp             1941               260    86.60%          11                 0   100.00%         451                13    97.12%         642               314    51.09%
Storages/Transaction/SchemaBuilder.cpp                  835               794     4.91%          46                42     8.70%        1030               958     6.99%         488               468     4.10%
Storages/Transaction/SchemaGetter.h                       1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 18494              4386    76.28%         345                84    75.65%        7263              1843    74.62%        6512              3389    47.96%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16860      9457             43.91%    189834  95844        49.51%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

@jiaqizho: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 14, 2022

Coverage for changed files

Filename                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/MockTiDB.cpp                                      149               145     2.68%          34                32     5.88%         450               432     4.00%          98                97     1.02%
Flash/Mpp/MPPTunnel.h                                     8                 8     0.00%           8                 8     0.00%          14                14     0.00%           0                 0         -
Interpreters/Settings.h                                   1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/Page/V3/BlobStore.cpp                          344               108    68.60%          38                 3    92.11%         748               201    73.13%         216                84    61.11%
Storages/Page/V3/BlobStore.h                              7                 1    85.71%           7                 1    85.71%          25                10    60.00%           0                 0         -
Storages/Page/V3/PageDirectory.cpp                      441                68    84.58%          30                 3    90.00%         986               195    80.22%         364                84    76.92%
Storages/Page/V3/PageDirectory.h                         24                 6    75.00%          24                 6    75.00%         101                21    79.21%           0                 0         -
Storages/Page/V3/PageDirectoryFactory.cpp                36                 8    77.78%           4                 0   100.00%         105                20    80.95%          42                 9    78.57%
Storages/Page/V3/PageEntriesEdit.h                       54                10    81.48%          39                 8    79.49%         157                42    73.25%          14                 6    57.14%
Storages/Page/V3/WAL/WALReader.cpp                       71                 9    87.32%           9                 0   100.00%         173                13    92.49%          54                12    77.78%
Storages/Page/V3/WAL/serialize.cpp                       47                11    76.60%          15                 1    93.33%         190                41    78.42%          52                16    69.23%
Storages/Page/V3/WALStore.cpp                            69                39    43.48%           8                 1    87.50%         119                42    64.71%          32                19    40.62%
Storages/Page/V3/tests/entries_helper.h                  65                36    44.62%          10                 3    70.00%         238               111    53.36%          32                21    34.38%
Storages/Page/V3/tests/gtest_blob_store.cpp            3457               576    83.34%          17                 0   100.00%         671                 0   100.00%        1072               506    52.80%
Storages/Page/V3/tests/gtest_page_directory.cpp        8494              1499    82.35%          46                 0   100.00%        1549                 7    99.55%        2672              1352    49.40%
Storages/Page/V3/tests/gtest_page_storage.cpp          2599               952    63.37%          31                 7    77.42%         704               154    78.12%         832               498    40.14%
Storages/Page/V3/tests/gtest_wal_store.cpp             1941               260    86.60%          11                 0   100.00%         451                13    97.12%         642               314    51.09%
Storages/Transaction/SchemaBuilder.cpp                  835               794     4.91%          46                42     8.70%        1030               958     6.99%         488               468     4.10%
Storages/Transaction/SchemaGetter.h                       1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 18643              4531    75.70%         379               116    69.39%        7713              2275    70.50%        6610              3486    47.26%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16860      9457             43.91%    189834  95842        49.51%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 41f18b5 into pingcap:master Mar 14, 2022
@JaySon-Huang JaySon-Huang deleted the rm-roll-ids branch March 14, 2022 12:27
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Mar 14, 2022
ywqzzy added a commit to ywqzzy/tiflash_1 that referenced this pull request Mar 14, 2022
Signed-off-by: ywqzzy <592838129@qq.com>

update.

Signed-off-by: ywqzzy <592838129@qq.com>

update.

Signed-off-by: ywqzzy <592838129@qq.com>

Split write and ingest throughput (pingcap#4245)

close pingcap#4243

Signed-off-by: ywqzzy <592838129@qq.com>

fix the problem that expired data was not recycled timely due to slow gc speed (pingcap#4224)

close pingcap#4146

Signed-off-by: ywqzzy <592838129@qq.com>

PageStorage: Fix some bugs (pingcap#4212)

ref pingcap#3594

Signed-off-by: ywqzzy <592838129@qq.com>

Make test of CreateTables using affected opts (pingcap#4239)

close pingcap#4235

Signed-off-by: ywqzzy <592838129@qq.com>

BlobStore: remove the old_ids, not need recycle the blob id. (pingcap#4247)

ref pingcap#3594

Signed-off-by: ywqzzy <592838129@qq.com>

support `PartitionTableScan` in TiFlash (pingcap#3876)

close pingcap#3873

Signed-off-by: ywqzzy <592838129@qq.com>

update.

Signed-off-by: ywqzzy <592838129@qq.com>

update.

Signed-off-by: ywqzzy <592838129@qq.com>

support last_day and dayofmonth pushdown to tiflash (pingcap#4183)

close pingcap#4149

Signed-off-by: ywqzzy <592838129@qq.com>
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants