Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) #5191

Merged
merged 13 commits into from
Jun 23, 2022
Merged

DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) #5191

merged 13 commits into from
Jun 23, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5166

What problem does this PR solve?

Issue Number: close #5154

Problem Summary:

What is changed and how it works?

in decodingSchemaSnapshot, we use column name instead of offset to find cluster index id of the common handle. Because in tiflash, we don't update the indexinfo of table_info except rename ddl action. Thus, the offset of tidb_table_info is not correctly in sometimes.

Besides, I add two DDL tests based on issue #5154, concerning about clustered index.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the TiFlash crash issue that occurs after dropping a column of a table with clustered indexes under some situations.

@hongyunyan @ti-chi-bot
This is an automated cherry-pick of pingcap#5166
02b7b27 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Jun 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 22, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 22, 2022
Merged
12 tasks
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR. labels Jun 22, 2022
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 22, 2022
@flowbehappy flowbehappy self-requested a review June 23, 2022 09:55
@hongyunyan
Copy link
Contributor

/run-all-tests

@lidezhu lidezhu added this to the v5.4.2 milestone Jun 23, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 23, 2022
@hongyunyan
Copy link
Contributor

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Jun 23, 2022

lines: 43.5% (50299 out of 115501)
branches: 6.5% (82323 out of 1266331)

JaySon-Huang
JaySon-Huang approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 23, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: c3d4fe9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 23, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Jun 23, 2022

lines: 43.5% (50300 out of 115501)
branches: 6.5% (82327 out of 1266331)

@ti-chi-bot ti-chi-bot merged commit 82c1eae into pingcap:release-5.4 Jun 23, 2022
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Sep 27, 2022
@ti-chi-bot @JaySon-Huang
DDL: Use Column Name Instead of Offset to Find the common handle clus…
c8bdab2 
…ter index (pingcap#5166) (pingcap#5191)

close pingcap#5154
@JaySon-Huang JaySon-Huang mentioned this pull request Sep 27, 2022
Merged
12 tasks
JaySon-Huang added a commit that referenced this pull request Oct 31, 2022
@JaySon-Huang @ti-chi-bot
Fix two DDL bugs on hotfix branch (#6042)
f0d54d6 
* DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) (#5191)

close #5154

* tests: Fix RegionBlockReaderTest helper functions (#5899) (#5924)

ref #5859

* Fix decode error when "NULL" value in the column with "primary key" flag (#5879) (#5932)

close #5859

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidezhu lidezhu lidezhu approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-5.4 This PR is cherry-picked to release-5.4 from a source PR.
Projects
None yet
Milestone
v5.4.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @hongyunyan @sre-bot @JaySon-Huang @lidezhu @VelocityLight