-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix decode error when "NULL" value in the column with "primary key" flag (#5879) #5932
Fix decode error when "NULL" value in the column with "primary key" flag (#5879) #5932
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/rebuild |
d5c138d
to
732fde4
Compare
/run-all-tests |
/run-all-tests |
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
55777b0
to
b6a59d1
Compare
/run-all-tests |
lines: 30.2% (3259 out of 10801) |
Signed-off-by: JaySon-Huang <tshent@qq.com>
/run-all-tests |
lines: 30.2% (3259 out of 10801) |
/merge |
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 4bfcc0a
|
lines: 30.2% (3259 out of 10801) |
/run-integration-test |
* DDL: Use Column Name Instead of Offset to Find the common handle cluster index (#5166) (#5191) close #5154 * tests: Fix RegionBlockReaderTest helper functions (#5899) (#5924) ref #5859 * Fix decode error when "NULL" value in the column with "primary key" flag (#5879) (#5932) close #5859 Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
This is an automated cherry-pick of #5879
What problem does this PR solve?
Issue Number: close #5859
Problem Summary:
TiFlash assumes all values in the column with "primary key" flag are non-null value.
However, users could create such "NULL" value in the "primary key" column by following steps
What is changed and how it works?
addDefaultValueToColumnIfPossible
insertRangeFrom
preHandleSnapshot
/ingestSST
Check List
Tests
Side effects
Documentation
Release note