Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Branch: merge master to planner_refactory #5426

Merged
merged 26 commits into from
Jul 25, 2022
Merged

Feature Branch: merge master to planner_refactory #5426

merged 26 commits into from
Jul 25, 2022

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jul 20, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #4739

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

lidezhu and others added 13 commits July 18, 2022 18:05
@lidezhu
clear obsolete v2 data for tables that totally transform to ps v3 (pi…
79c3936 
…ngcap#5373)

close pingcap#5336
@Willendless
Enhance executor join tests (pingcap#5305)
5d680c4 
close pingcap#5198
@lidezhu
change some default config of ps v3 (pingcap#5398)
75dbc1c 
ref pingcap#3594
@JinheLin
Update tipb: add keep_order field in TableScan (pingcap#5400)
21dea59 
ref pingcap#5376
@CalvinNeo
Support pre_exec in Proxy (pingcap#5386)
e737618 
ref pingcap#5170
@windtalker
refine log in creating set for join build (pingcap#5404)
5792db6 
close pingcap#5403
@yibin87
Fix async sender nullptr bug (pingcap#5407)
6560ada 
close pingcap#5405
@hongyunyan
Update schema version in set tiflash mode (pingcap#5402)
c0f7cac 
ref pingcap#5252
@xzhangxian1008
Test aggregation functions (pingcap#5364)
29330a2 
ref pingcap#5347
@fuzhe1989
DAGContext: remove useless explicitly call to tunnel_set's default ct…
079d3c9 
…or (pingcap#5417)

ref pingcap#5416
@zanmato1984
Fix extract fullstack test (pingcap#5420)
4abef77 
close pingcap#5421
@breezewish
Yield CPU for concurrent flush and concurrent mergeDelta (pingcap#5410)
9ccfc4b 
close pingcap#5409
@SeaRise
fix the incorrect execution time of join in explain analyze (pingcap#…
cecbe66 
…5411)

close pingcap#5412
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Lloyd-Pottiger
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 20, 2022
@SeaRise SeaRise changed the base branch from master to planner_refactory July 20, 2022 07:36
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 20, 2022

/label tide/merge-method-rebase

@ti-chi-bot
Copy link
Member

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ywqzzy
ywqzzy approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ywqzzy ywqzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 20, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 20, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 20, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 20, 2022

/label tide/merge-method-rebase

@ti-chi-bot
Copy link
Member

@SeaRise: The label(s) tide/merge-method-rebase cannot be applied, because the repository doesn't have them.

In response to this:

/label tide/merge-method-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 21, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 21, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 21, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 21, 2022

/run-integration-test

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 21, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18927      9469             49.97%    215979  95658        55.71%

full coverage report (for internal network access only)

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 21, 2022

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 22, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

remove /label tide/merge-method-rebase

@SeaRise SeaRise removed the tide/merge-method-rebase Denotes a PR that should be rebased by tide when it merges. label Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/merge cancel

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/label tide/merge-method-merge

@ti-chi-bot ti-chi-bot added the tide/merge-method-merge Denotes a PR that should be merge by tide when it merges. label Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 467fb68

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 25, 2022
@SeaRise
Copy link
Contributor Author

SeaRise commented Jul 25, 2022

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Jul 25, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18927      9470             49.97%    215979  95678        55.70%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit aa20f61 into pingcap:planner_refactory Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. tide/merge-method-merge Denotes a PR that should be merge by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

interpreter planner refactor