Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageStorage: Log down the gc time for external pages (#5739) #5753

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5739

What problem does this PR solve?

Issue Number: ref #5697

Problem Summary:
The GC total time in logging does not include the time costs in clean_external_page.

What is changed and how it works?

  • Add a struct GCTimeStatistics to handle logging
  • Add the time cost in cleanExternalPage into GC total time
  • Add ExternalIdsByNamespace to
    • Manage external ids by namespace
    • Shorten the GC time of cleaning external pages from 2500+ms to 420ms with about 5000 empty tables
# before
[2022/08/31 13:06:27.762 +08:00] [DEBUG] [PageStorageImpl.cpp:330] ["PageStorage:__global__.data GC finished without full gc. [total time=2514ms] [dump snapshots=0ms] [gc in mem entries=1ms] [blobstore remove entries=0ms] [blobstore get status=0ms] [get gc entries=0ms] [blobstore full gc=0ms] [gc apply=0ms] [external callbacks=4933] [external gc=2512ms] [get alive=2098.75ms] [scanner=408.65ms] [remover=4.90ms]"] [thread_id=163]

# after
[2022/08/31 13:10:22.715 +08:00] [DEBUG] [PageStorageImpl.cpp:330] ["PageStorage:__global__.data GC finished without full gc. [total time=427ms] [dump snapshots=0ms] [gc in mem entries=1ms] [blobstore remove entries=0ms] [blobstore get status=0ms] [get gc entries=0ms] [blobstore full gc=0ms] [gc apply=0ms] [external callbacks=4933] [external gc=425ms] [get alive=14.70ms] [scanner=407.08ms] [remover=3.83ms]"] [thread_id=136]

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Aug 31, 2022
@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 31, 2022
JaySon-Huang and others added 4 commits September 1, 2022 00:36
Signed-off-by: JaySon-Huang <tshent@qq.com>
close pingcap#5444

 Conflicts:
	dbms/src/Common/FailPoint.cpp
	dbms/src/Common/FailPoint.h
	dbms/src/Flash/Coprocessor/DAGQueryBlockInterpreter.cpp
	dbms/src/Flash/Mpp/ExchangeReceiver.cpp
ref pingcap#5527

 Conflicts:
	dbms/src/Flash/Coprocessor/DAGQueryBlockInterpreter.cpp
	dbms/src/Flash/Coprocessor/GenSchemaAndColumn.cpp
	dbms/src/Flash/Mpp/ExchangeReceiver.cpp
	dbms/src/Flash/Planner/ExecutorIdGenerator.h
	dbms/src/Flash/Planner/FinalizeHelper.cpp
	dbms/src/Flash/Planner/PhysicalPlan.cpp
	dbms/src/Flash/Planner/plans/PhysicalExchangeSender.cpp
	dbms/src/Flash/Planner/plans/PhysicalTableScan.cpp
	dbms/src/TestUtils/InputStreamTestUtils.cpp
@JaySon-Huang JaySon-Huang force-pushed the cherry-pick-5739-to-release-6.1 branch from ac8cbcd to 30171bc Compare August 31, 2022 16:42
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@flowbehappy
Copy link
Contributor

I think we don't need to pick to v6.1

@JaySon-Huang
Copy link
Contributor

closed as not planned to enable ps v3 in 6.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants