Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raft: Add identifier to logger when wait index happens(release-7.1) #8473

Merged
merged 7 commits into from
Dec 7, 2023

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 6, 2023

manual cherry-pick of #8446

What problem does this PR solve?

Issue Number: close #8448, close #8076

Problem Summary:

What is changed and how it works?

logging after this PR will print the "source=request_identifier" into logging, along with the index info and time elapsed

[2023/11/30 21:51:23.688 +08:00] [DEBUG] [LearnerReadWorker.cpp:317] ["[Learner Read] Batch read index, num_regions=1 num_requests=1 num_stale_read=0 num_cached_index=0 num_unavailable=0 cost=2ms"] [source="MPP<gather_id:1, query_ts:1701352283678367892, local_query_id:11, server_id:956, start_ts:445999293050388482,task_id:1>"] [thread_id=271]
[2023/11/30 21:51:30.827 +08:00] [INFO] [ReadIndex.cpp:100] ["[region_id=188005] wait learner index done, prev_index=8 curr_index=9 to_wait=9 elapsed_s=7.139 timeout_s=300.000"] [source="MPP<gather_id:1, query_ts:1701352283678367892, local_query_id:11, server_id:956, start_ts:445999293050388482,task_id:1>"] [thread_id=271]
[2023/11/30 21:51:30.827 +08:00] [DEBUG] [LearnerReadWorker.cpp:416] ["[Learner Read] Finish wait index and resolve locks, wait_cost=7139ms n_regions=1 n_unavailable=0"] [source="MPP<gather_id:1, query_ts:1701352283678367892, local_query_id:11, server_id:956, start_ts:445999293050388482,task_id:1>"] [thread_id=271]

image
image
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that the max-quantile metrics are displayed incorrectly on Grafana

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 6, 2023
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 6, 2023
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 7, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 7, 2023
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 7, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 7, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-07 02:51:28.672125629 +0000 UTC m=+1668717.337351823: ☑️ agreed by JinheLin.
  • 2023-12-07 03:34:51.330529892 +0000 UTC m=+1671319.995756072: ☑️ agreed by CalvinNeo.

@ti-chi-bot ti-chi-bot bot merged commit bb529e6 into pingcap:release-7.1 Dec 7, 2023
4 of 5 checks passed
@JaySon-Huang JaySon-Huang deleted the add_more_metrics_7.1 branch December 7, 2023 03:39
@JaySon-Huang
Copy link
Contributor Author

/cherry-pick release-7.5

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 7, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-7.5: #8474.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@JaySon-Huang
Copy link
Contributor Author

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-6.5: #8475.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 7, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@JaySon-Huang
Copy link
Contributor Author

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-6.1: #8476.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Dec 7, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants