Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Raft: Add identifier to logger when wait index happens(release-6.1) (#8473) #8476

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8473

manual cherry-pick of #8446

What problem does this PR solve?

Issue Number: close #8448, close #8076

Problem Summary:

What is changed and how it works?

logging after this PR will print the "source=request_identifier" into logging, along with the index info and time elapsed

[2023/11/30 21:51:23.688 +08:00] [DEBUG] [LearnerReadWorker.cpp:317] ["[Learner Read] Batch read index, num_regions=1 num_requests=1 num_stale_read=0 num_cached_index=0 num_unavailable=0 cost=2ms"] [source="MPP<gather_id:1, query_ts:1701352283678367892, local_query_id:11, server_id:956, start_ts:445999293050388482,task_id:1>"] [thread_id=271]
[2023/11/30 21:51:30.827 +08:00] [INFO] [ReadIndex.cpp:100] ["[region_id=188005] wait learner index done, prev_index=8 curr_index=9 to_wait=9 elapsed_s=7.139 timeout_s=300.000"] [source="MPP<gather_id:1, query_ts:1701352283678367892, local_query_id:11, server_id:956, start_ts:445999293050388482,task_id:1>"] [thread_id=271]
[2023/11/30 21:51:30.827 +08:00] [DEBUG] [LearnerReadWorker.cpp:416] ["[Learner Read] Finish wait index and resolve locks, wait_cost=7139ms n_regions=1 n_unavailable=0"] [source="MPP<gather_id:1, query_ts:1701352283678367892, local_query_id:11, server_id:956, start_ts:445999293050388482,task_id:1>"] [thread_id=271]

image
image
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the issue that the max-quantile metrics are displayed incorrectly on Grafana

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Dec 7, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JaySon-Huang JaySon-Huang changed the title Raft: Add identifier to logger when wait index happens(release-7.1) (#8473) Raft: Add identifier to logger when wait index happens(release-6.1) (#8473) Dec 7, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 3, 2024
@JaySon-Huang JaySon-Huang changed the title Raft: Add identifier to logger when wait index happens(release-6.1) (#8473) [WIP] Raft: Add identifier to logger when wait index happens(release-6.1) (#8473) Jan 3, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants