Refine cancel for read thread stream

[SeaRise]

What problem does this PR solve?

Issue Number: ref #8505

Problem Summary:

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[SeaRise]

/cc @gengliqi @windtalker @JinheLin

[JinheLin]

Where did you call cancel?

[SeaRise]

called here

tiflash/dbms/src/Flash/Mpp/MPPTask.cpp

Lines 183 to 190 in 5417d84

	void MPPTask::abortQueryExecutor()
	{
	if (auto query_executor = query_executor_holder.tryGet(); query_executor)
	{
	assert(query_executor.value());
	(*query_executor)->cancel();
	}
	}

[SeaRise]

tiflash/dbms/src/Flash/Executor/DataStreamExecutor.cpp

Lines 61 to 65 in 5417d84

	void DataStreamExecutor::cancel()
	{
	if (auto * p_stream = dynamic_cast<IProfilingBlockInputStream *>(data_stream.get()); p_stream)
	p_stream->cancel(/*kill=*/false);
	}

[gengliqi]

tiflash/dbms/src/DataStreams/MultiplexInputStream.h

Lines 157 to 173 in 5417d84

	void cancel(bool kill) override
	{
	if (kill)
	is_killed = true;
	bool old_val = false;
	if (!is_cancelled.compare_exchange_strong(old_val, true, std::memory_order_seq_cst, std::memory_order_relaxed))
	return;
	if (cur_stream)
	{
	if (auto * child = dynamic_cast<IProfilingBlockInputStream *>(&*cur_stream))
	{
	child->cancel(kill);
	}
	}
	}

It seems that cancel will not be called for UnorderedInputStream in shared_pool.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JinheLin,gengliqi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2023-12-13 05:44:02.679929085 +0000 UTC m=+421333.717156011: ☑️ agreed by gengliqi.
• 2023-12-13 06:26:24.032276185 +0000 UTC m=+423875.069503112: ☑️ agreed by JinheLin.

[ti-chi-bot]

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.5: #8516.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #8517.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-7.1: #8518.