Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine cancel for read thread stream (#8511) (#8517) #8528

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8517

This is an automated cherry-pick of #8511

What problem does this PR solve?

Issue Number: ref #8505

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

SeaRise and others added 3 commits December 15, 2023 03:11
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
Signed-off-by: gengliqi <gengliqiii@gmail.com>
@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 15, 2023
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. type/cherry-pick-for-release-6.5-20231215-v6.5.3 labels Dec 15, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 15, 2023
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 15, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gengliqi, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gengliqi,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 15, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-15 03:12:42.611609911 +0000 UTC m=+585053.648836837: ☑️ agreed by gengliqi.
  • 2023-12-15 03:14:32.56983138 +0000 UTC m=+585163.607058306: ☑️ agreed by windtalker.

@gengliqi
Copy link
Contributor

/run-all-tests

@gengliqi
Copy link
Contributor

/run-integration-test tidb=release-6.5

@gengliqi
Copy link
Contributor

/run-unit-test tidb=release-6.5

@gengliqi
Copy link
Contributor

/run-integration-test tidb=release-6.5

@gengliqi
Copy link
Contributor

/run-unit-test tidb=release-6.5

@gengliqi gengliqi merged commit d994e68 into pingcap:release-6.5-20231215-v6.5.3 Dec 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20231215-v6.5.3 type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants