Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsan suppression file to ignore false positive warnings #8529

Closed
wants to merge 9 commits into from

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Dec 15, 2023

What problem does this PR solve?

Issue Number: ref #8285

Problem Summary:

In PR #8499, try add AssignDescriptors to tsan suppression to ignore false positive warnings. However, the tool fails to recognize and ignore some cases(write code is protected by call_once):
gRUZHBl5IB

8mz1Eue6r7

What is changed and how it works?

Ignore high level functions: DebugString and ShortDebugString

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 15, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yibin87. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 15, 2023
@yibin87 yibin87 requested review from windtalker and xzhangxian1008 and removed request for windtalker and xzhangxian1008 December 15, 2023 04:24
@yibin87 yibin87 closed this Dec 15, 2023
@yibin87 yibin87 deleted the tsan_fix branch December 15, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants