Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed. (#8671) #8672

Merged
merged 2 commits into from
Jan 7, 2024
Merged

Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed. (#8671) #8672

merged 2 commits into from
Jan 7, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8671

What problem does this PR solve?

Issue Number: close #8601

Problem Summary:

What is changed and how it works?

see #8601 (comment)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed.

@SeaRise @ti-chi-bot
This is an automated cherry-pick of pingcap#8671
7d0ff20 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Jan 5, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 5, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 5, 2024
JaySon-Huang
JaySon-Huang approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 6, 2024
@JaySon-Huang
Copy link
Contributor

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,SeaRise]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 7, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-06 06:15:12.824986735 +0000 UTC m=+78302.409240423: ☑️ agreed by JaySon-Huang.
  • 2024-01-07 07:03:25.705472914 +0000 UTC m=+167595.289726602: ☑️ agreed by SeaRise.

@SeaRise
Copy link
Contributor

SeaRise commented Jan 7, 2024

/run-all-tests

@JaySon-Huang
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jan 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit a744148 into pingcap:release-7.5 Jan 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeaRise SeaRise SeaRise approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@SeaRise SeaRise

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @JaySon-Huang @SeaRise