Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed. #8671

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed. #8671

merged 7 commits into from
Jan 5, 2024

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Jan 5, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8601

Problem Summary:

What is changed and how it works?

see #8601 (comment)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2024
@SeaRise SeaRise changed the title fix issue 8601 Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed. Jan 5, 2024
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jan 5, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed do-not-merge/needs-triage-completed labels Jan 5, 2024
JaySon-Huang
JaySon-Huang approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 5, 2024
@JaySon-Huang
Copy link
Contributor

JaySon-Huang commented Jan 5, 2024 •
edited
Loading

Can we add a test with remote read (by failpoints) that triggers this bug?

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 5, 2024

Can we add a test with remote read (by failpoints) that triggers this bug?

Sure, but it may not necessarily trigger the issue as the sync schema may have already been asynchronously triggered.

@JaySon-Huang
Copy link
Contributor

Can we add a test with remote read (by failpoints) that triggers this bug?

Sure, but it may not necessarily trigger the issue as the sync schema may have already been asynchronously triggered.

You can disable the schema sync background task by => DBGInvoke __enable_schema_sync_service('false')

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 5, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
@SeaRise SeaRise force-pushed the fix_time_fsp_in_remote_read branch from bc9ff62 to 10e08a1 Compare January 5, 2024 10:47
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 5, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 5, 2024

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 5, 2024

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 5, 2024

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
windtalker
windtalker approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 5, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 10:06:54.196271951 +0000 UTC m=+5803.780525635: ☑️ agreed by JaySon-Huang.
  • 2024-01-05 12:15:32.391310387 +0000 UTC m=+13521.975564073: ☑️ agreed by windtalker.

@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 5, 2024

/run-unit-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Jan 5, 2024

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 383e1bd into pingcap:master Jan 5, 2024
6 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #8672.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Jan 5, 2024
@SeaRise @ti-chi-bot
This is an automated cherry-pick of pingcap#8671
7d0ff20 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 5, 2024
Merged
12 tasks
@SeaRise SeaRise deleted the fix_time_fsp_in_remote_read branch January 5, 2024 18:15
ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2024
@ti-chi-bot
Fix an issue where a query may throw an error during a remote read an…
a744148 
…d the precision of a duration data type is changed. (#8671) (#8672)

close #8601
@JaySon-Huang JaySon-Huang mentioned this pull request Mar 1, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Mar 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8814.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 1, 2024
@SeaRise @ti-chi-bot
This is an automated cherry-pick of pingcap#8671
75df7e0 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 1, 2024
Closed
12 tasks
@JaySon-Huang JaySon-Huang mentioned this pull request Mar 4, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Mar 4, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8819.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 4, 2024
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 4, 2024
@SeaRise @ti-chi-bot
This is an automated cherry-pick of pingcap#8671
fc1f44f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. label Apr 1, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8880.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Apr 1, 2024
@SeaRise @ti-chi-bot
This is an automated cherry-pick of pingcap#8671
5df6a20 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 1, 2024
Closed
12 tasks
@JaySon-Huang JaySon-Huang mentioned this pull request Apr 1, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@SeaRise @JaySon-Huang @ti-chi-bot @windtalker