-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed (release-6.5) #8816
Merged
ti-chi-bot
merged 5 commits into
pingcap:release-6.5
from
JaySon-Huang:fix_time_fsp_in_remote_read_65
Mar 5, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/cherry-pick-not-approved
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Mar 4, 2024
Lloyd-Pottiger
approved these changes
Mar 4, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Mar 4, 2024
SeaRise
approved these changes
Mar 4, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Lloyd-Pottiger, SeaRise The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Mar 4, 2024
/run-unit-test |
This was referenced Mar 5, 2024
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Apr 1, 2024
…ad and the precision of a duration data type is changed (release-6.5) (pingcap#8816) close pingcap#8601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an manual fix of #8671 in release-6.5
What problem does this PR solve?
Issue Number: close #8601
Problem Summary:
What is changed and how it works?
see #8601 (comment). The different in release-7.1 and earlier branches is because the fsp change of
time
column type is ignoredCheck List
Tests
Side effects
Documentation
Release note