Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed (release-6.5) #8816

Merged

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Mar 4, 2024

This is an manual fix of #8671 in release-6.5

What problem does this PR solve?

Issue Number: close #8601

Problem Summary:

What is changed and how it works?

see #8601 (comment). The different in release-7.1 and earlier branches is because the fsp change of time column type is ignored

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix an issue where a query may throw an error during a remote read and the precision of a duration data type is changed.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 4, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 4, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Lloyd-Pottiger, SeaRise

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,SeaRise]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-04 08:55:19.738465737 +0000 UTC m=+70946.760712124: ☑️ agreed by Lloyd-Pottiger.
  • 2024-03-04 08:57:27.974654955 +0000 UTC m=+71074.996901344: ☑️ agreed by SeaRise.

@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 4, 2024
@Lloyd-Pottiger
Copy link
Contributor

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit b2a76f1 into pingcap:release-6.5 Mar 5, 2024
5 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_time_fsp_in_remote_read_65 branch March 5, 2024 02:56
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Apr 1, 2024
…ad and the precision of a duration data type is changed (release-6.5) (pingcap#8816)

close pingcap#8601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants