Static dispatch Arm-optimized-routines instead of dynamic dispatch #8892
Conversation
ti-chi-bot
bot
added
release-note-none
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
ti-chi-bot
bot
added
size/XL
ti-chi-bot
bot
added
needs-1-more-lgtm
ti-chi-bot
bot
removed
the
needs-rebase
| ALWAYS_INLINE static inline void * inline_memcpy(void * __restrict dst_, const void * __restrict src_, size_t size) | ||
| { | ||
| #if __aarch64__ | ||
| #if __ARM_FEATURE_SVE | ||
| return __memcpy_aarch64_sve(dst_, src_, size); | ||
| #elif __ARM_NEON | ||
| return __memcpy_aarch64_simd(dst_, src_, size); | ||
| #endif | ||
| return __memcpy_aarch64(dst_, src_, size); | ||
| #elif __arm__ | ||
| return __memcpy_arm(dst_, src_, size); | ||
| #else | ||
| return memcpy(dst_, src_, size); | ||
| #endif | ||
| } |
There was a problem hiding this comment.
Can this file get the correct macro for __ARM_FEATURE_SVE / __ARM_NEON, etc?
There was a problem hiding this comment.
I'm not sure where these macro is defined. Are they defined in the arm system header?
There was a problem hiding this comment.
Yes, I have verified.
They are introduced by flag, like "+simd" will add macro __ARM_NEON.
https://developer.arm.com/documentation/dui0774/l/Other-Compiler-specific-Features/Predefined-macros
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/run-all-tests |
What problem does this PR solve?
Issue Number: ref #7193
Problem Summary:
What is changed and how it works?
hook syscall may make
getauxvalfailed which may cause core dump.Check List
Tests
Side effects
Documentation
Release note