Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang 17 & C++23 Compatibility #7193

Closed
breezewish opened this issue Mar 31, 2023 · 1 comment · Fixed by #8537, #8899 or #9164
Closed

Clang 17 & C++23 Compatibility #7193

breezewish opened this issue Mar 31, 2023 · 1 comment · Fixed by #8537, #8899 or #9164
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@breezewish
Copy link
Member

Enhancement

Clang 16.0.0 was officially released 2 weeks ago (March, 2023).

https://github.com/llvm/llvm-project/releases/tag/llvmorg-16.0.0
@breezewish breezewish added the type/enhancement The issue or PR belongs to an enhancement. label Mar 31, 2023
@breezewish breezewish mentioned this issue Mar 31, 2023
Merged
13 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 31, 2023
@breezewish
Clang16 compatibility (#7194)
63a0113 
ref #7193
@JaySon-Huang JaySon-Huang mentioned this issue Nov 8, 2023
Closed
@JaySon-Huang
Copy link
Contributor

Change it to clang-17 that 17.0.4 was released on oct 31st

@JaySon-Huang JaySon-Huang changed the title Clang 16 Compatibility Clang 17 Compatibility Nov 8, 2023
@JaySon-Huang JaySon-Huang mentioned this issue Dec 12, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 12, 2023
@JaySon-Huang
*: Fix compile error under clang 17 (#8503)
384a449 
ref #7193
This was referenced Jan 2, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jan 2, 2024
@JaySon-Huang
*: Add compiler info to the tiflash version (#8640)
7d6bec8 
ref #7193
@Lloyd-Pottiger Lloyd-Pottiger mentioned this issue Apr 2, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in #8537 Apr 2, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 2, 2024
@JaySon-Huang
Update toolchain to Clang 17 (#8537)
52fc334 
close #7193, close #8890
ti-chi-bot bot pushed a commit that referenced this issue Apr 2, 2024
@Lloyd-Pottiger
Static dispatch Arm-optimized-routines instead of dynamic dispatch (#…
f04b16d 
…8892)

ref #7193
@JaySon-Huang JaySon-Huang mentioned this issue Apr 10, 2024
Merged
12 tasks
@JaySon-Huang JaySon-Huang reopened this Apr 10, 2024
@JaySon-Huang JaySon-Huang mentioned this issue Apr 10, 2024
Merged
12 tasks
@JaySon-Huang JaySon-Huang changed the title Clang 17 Compatibility Clang 17 & C++23 Compatibility Apr 10, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 11, 2024
@JaySon-Huang
*: Keep clang13 (#8930)
94f15d1 
ref #7193
@ti-chi-bot ti-chi-bot mentioned this issue Apr 11, 2024
Closed
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Apr 11, 2024
@JaySon-Huang
*: Keep clang13 (release-8.1) (#8931)
e3f77a2 
ref #7193
This was referenced Apr 11, 2024
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Apr 15, 2024
@Lloyd-Pottiger
build: Suppress warnings (#8948)
73f37f6 
ref #7193
@breezewish breezewish mentioned this issue Apr 22, 2024
Open
13 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 06427c4 Jun 25, 2024
@Lloyd-Pottiger Lloyd-Pottiger mentioned this issue Jun 26, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 27, 2024
@Lloyd-Pottiger
*: update minimum cmake version to 3.23 (#9164)
8a53e36 
close #7193, close #8898

update minimum cmake version to 3.23

Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@JaySon-Huang JaySon-Huang mentioned this issue Jun 27, 2024
Closed
@ti-chi-bot ti-chi-bot mentioned this issue Jun 28, 2024
Merged
12 tasks
This was referenced Jul 1, 2024
Merged
Merged
Merged
Merged
Merged
ti-chi-bot bot pushed a commit to PingCAP-QE/ci that referenced this issue Jul 3, 2024
@JaySon-Huang
Fix building tiflash-sanitizer (#3019)
61a4fa1 
### **User description**
Fix that git considers the directory as not safe, making tiflash
sanitizer failed to build



https://ci.pingcap.net/blue/organizations/jenkins/tiflash-sanitizer-daily/detail/tiflash-sanitizer-daily/1987/pipeline/
```
[2024-07-01T18:48:01.172Z] fatal: detected dubious ownership in repository at '/home/jenkins/agent/workspace/tiflash-sanitizer-daily/tiflash'
[2024-07-01T18:48:01.172Z] To add an exception for this directory, call:
[2024-07-01T18:48:01.172Z] 
[2024-07-01T18:48:01.172Z] 	git config --global --add safe.directory /home/jenkins/agent/workspace/tiflash-sanitizer-daily/tiflash
```

ref pingcap/tiflash#7193

___

### **PR Type**
Bug fix, Configuration changes


___

### **Description**
- Added commands to configure Git safe directories to avoid build
failures due to dubious ownership detection.
- Ensured the directories `${curws}/tiflash/contrib/tiflash-proxy` and
`${curws}/tiflash` are marked as safe.



___



### **Changes walkthrough** 📝
<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Configuration
changes</strong></td><td><table>
<tr>
  <td>
    <details>

<summary><strong>tiflash-sanitizer-daily.groovy</strong><dd><code>Configure
Git safe directories for tiflash-sanitizer build</code></dd></summary>
<hr>
      
jenkins/pipelines/ci/tiflash/tiflash-sanitizer-daily.groovy

<li>Added commands to configure Git safe directories.<br> <li> Ensured
the directories used in the build process are marked as safe.<br>


</details>
    

  </td>
<td><a
href="https://github.com/PingCAP-QE/ci/pull/3019/files#diff-cf6e0f80b8d57ff16c04804cccb20aa2048f6041c6c159d041d860881b6fb9ae">+5/-0</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>                    
</table></td></tr></tr></tbody></table>

___

> 💡 **PR-Agent usage**:
>Comment `/help` on the PR to get a list of all available PR-Agent tools
and their descriptions
This was referenced Aug 6, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
3 participants
@breezewish @JaySon-Huang @ti-chi-bot