Update toolchain to Clang 17 #8537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
|
Hi, because here specify image_tag_suffix in .toolchain.yml, to ensure that build-common can pull images properly, need to confirm if this image ci groovy file https://github.com/PingCAP-QE/ci/blob/main/jenkins/pipelines/ci/tiflash/tiflash-build-common.groovy#L453 |
ti-chi-bot
bot
added
size/L
ti-chi-bot
bot
added
size/XXL
JaySon-Huang
force-pushed
the
clang-17-support-test
branch
from
1ec1737
to
48b47b3
Compare
ti-chi-bot
bot
added
size/L
ti-chi-bot bot
pushed a commit
to PingCAP-QE/ci
that referenced
this pull request
Jan 2, 2024
Try to build tiflash using clang-17 docker image pingcap/tiflash#8537 But the CI will run into errors like https://ci.pingcap.net/job/tiflash-build-common/33843/console ``` [2023-12-30T15:06:42.887Z] + git log -1 --format=%H [2023-12-30T15:06:42.887Z] fatal: detected dubious ownership in repository at '/home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/tiflash-proxy' [2023-12-30T15:06:42.887Z] To add an exception for this directory, call: ``` ``` 23:16:59 fatal: detected dubious ownership in repository at '/home/jenkins/agent/workspace/tiflash-build-common/tiflash' 23:16:59 To add an exception for this directory, call: 23:16:59 23:16:59 git config --global --add safe.directory /home/jenkins/agent/workspace/tiflash-build-common/tiflash 23:16:59 CMake Error at dbms/cmake/version.cmake:20 (execute_process): 23:16:59 execute_process failed command indexes: 23:16:59 23:16:59 1: "Child return code: 128" 23:16:59 23:16:59 Call Stack (most recent call first): 23:16:59 dbms/CMakeLists.txt:25 (include) ``` Add git safe.directory to workaround the errors. After these changes, the pipeline can build tiflash with clang-17 successfully: https://ci.pingcap.net/job/tiflash-build-common/33844/consoleFull Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
commented
Jan 2, 2024
JaySon-Huang
force-pushed
the
clang-17-support-test
branch
from
0822104
to
53d84c8
Compare
ti-chi-bot
bot
added
size/M
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: SchrodingerZhu <i@zhuyi.fan>
Signed-off-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang
force-pushed
the
clang-17-support-test
branch
from
17d2d92
to
44126df
Compare
Lloyd-Pottiger
approved these changes
Apr 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
|
The latest MacOS 14.4.1 only provides clang 15 by default, so I keep require AppleClang 15.0.0+ by now |
|
/run-all-tests |
Seems timeout. |
|
/run-unit-test |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
/run-all-tests |
|
/run-unit-test |
ti-chi-bot
bot
added
release-note
|
download tiflash binary(linux amd64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/b3c8b8b3af8e246054bfe2746fe9df86cc90e993/centos7/tiflash-linux-amd64.tar.gz |
|
download tiflash binary(linux arm64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/master/b3c8b8b3af8e246054bfe2746fe9df86cc90e993/centos7/tiflash-linux-arm64.tar.gz |
ti-chi-bot
bot
added
release-note-none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #7193, close #8890
Problem Summary:
What is changed and how it works?
Use clang-17.0.6 for CI/CD building since this PR merged. Other branches keep using clang-13.
Check List
Tests
tpch50, 1 tidb, 1 tikv, 1 tiflash, https://github.com/pingcap/tiflash/tree/c15fcc2bf83c6e1230c43a0daaccdc00fb15304f
Side effects
Documentation
Release note