Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building tiflash using clang-17 docker image #2712

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 30, 2023

Try to build tiflash using clang-17 docker image pingcap/tiflash#8537, ref pingcap/tiflash#7193

But the CI will run into errors like https://ci.pingcap.net/job/tiflash-build-common/33843/console

[2023-12-30T15:06:42.887Z] + git log -1 --format=%H
[2023-12-30T15:06:42.887Z] fatal: detected dubious ownership in repository at '/home/jenkins/agent/workspace/tiflash-build-common/tiflash/contrib/tiflash-proxy'
[2023-12-30T15:06:42.887Z] To add an exception for this directory, call:
23:16:59  fatal: detected dubious ownership in repository at '/home/jenkins/agent/workspace/tiflash-build-common/tiflash'
23:16:59  To add an exception for this directory, call:
23:16:59  
23:16:59  	git config --global --add safe.directory /home/jenkins/agent/workspace/tiflash-build-common/tiflash
23:16:59  CMake Error at dbms/cmake/version.cmake:20 (execute_process):
23:16:59    execute_process failed command indexes:
23:16:59  
23:16:59      1: "Child return code: 128"
23:16:59  
23:16:59  Call Stack (most recent call first):
23:16:59    dbms/CMakeLists.txt:25 (include)

Add git safe.directory to workaround the errors. After these changes, the pipeline can build tiflash with clang-17 successfully: https://ci.pingcap.net/job/tiflash-build-common/33844/consoleFull

Signed-off-by: JaySon-Huang <tshent@qq.com>
Copy link

ti-chi-bot bot commented Dec 30, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

The pull request makes changes to fix building tiflash using clang-17 docker image. The changes include adding git safe.directory to work around the errors. After these changes, the pipeline can build tiflash with clang-17 successfully.

Key Changes

  • Addition of git safe.directory to work around errors while building tiflash.

Potential Problems

  • None found.

Fixing Suggestions

  • No further fixes are needed.

Overall, the changes made in the pull request seem to be good, and I see no potential problems. Therefore, I recommend merging the pull request.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and wuhuizuo December 30, 2023 16:00
@ti-chi-bot ti-chi-bot bot added the size/XS label Dec 30, 2023
Copy link
Collaborator

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 2, 2024
Copy link

ti-chi-bot bot commented Jan 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-02 03:59:05.7769588 +0000 UTC m=+2143036.814185725: ☑️ agreed by purelind.

Copy link

ti-chi-bot bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit a5cf22b into PingCAP-QE:main Jan 2, 2024
1 of 2 checks passed
@JaySon-Huang JaySon-Huang deleted the fix_tiflash_build branch January 2, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants