-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Adaptive Lightweight Compression Algorithm #8903
Support Adaptive Lightweight Compression Algorithm #8903
Conversation
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
599220e
to
1c0d983
Compare
e0ea397
to
42f4603
Compare
d88a3f7
to
530b134
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
7e0ecf2
to
c840f56
Compare
0ab7c73
to
160114f
Compare
e394c9b
to
63038b0
Compare
dbms/src/IO/Compression/CompressionCodecLightweight_Integer.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
dbms/src/IO/Compression/CompressionCodecLightweight_Integer.cpp
Outdated
Show resolved
Hide resolved
/hold |
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
memcpy(dest, src, sizeof(T)); | ||
if (unlikely(source_size <= sizeof(T))) | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The check of source_size > sizeof(T)
should be done before memcpy
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
==
here, fixed.
The following make sure source_size >= sizeof(T)
.
void CompressionCodecDeltaFOR::doDecompressData(
const char * source,
UInt32 source_size,
char * dest,
UInt32 uncompressed_size) const
{
if (unlikely(source_size < 2))
throw Exception(
ErrorCodes::CANNOT_DECOMPRESS,
"Cannot decompress DeltaFor-encoded data. File has wrong header");
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JaySon-Huang, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
What problem does this PR solve?
Issue Number: close #8982
Problem Summary:
What is changed and how it works?
Support Adaptive Lightweight Compression Algorithm
Check List
Tests
Side effects
Documentation
Release note