Common: support bitpacking #8969
Conversation
ti-chi-bot
bot
added
release-note-none
contrib/fastpforlib/bitpacking.cpp
Outdated
There was a problem hiding this comment.
why copying the files rather than adding them as submodule? It may bring trouble when we want to update the version of fastpfor
There was a problem hiding this comment.
Using https://github.com/lemire/FastPFor to support Bit-Packing encoding. But it only supports 32bits and 64 bits.
There was a problem hiding this comment.
https://github.com/powturbo/TurboPFor-Integer-Compression is the best, but it is GPL
There was a problem hiding this comment.
Can we use the bitpacking in FastPFor? https://github.com/lemire/FastPFor/blob/master/headers/blockpacking.h
There was a problem hiding this comment.
It only supports 32bits.
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Lloyd-Pottiger
force-pushed
the
support-pfor
branch
from
a1251bd
to
64deccb
Compare
Co-authored-by: jinhelin <linjinhe33@gmail.com>
Lloyd-Pottiger
force-pushed
the
support-pfor
branch
from
1d4016c
to
31fab1c
Compare
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Use minmax_element
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/run-all-tests |
What problem does this PR solve?
Issue Number: ref #8789
Problem Summary:
What is changed and how it works?
Using https://github.com/lemire/FastPFor to support Bit-Packing encoding. But it only supports 32bits and 64 bits, so most of the codes come from https://github.com/duckdb/duckdb/tree/main/third_party/fastpforlib
Part of #8903
Check List
Tests
Side effects
Documentation
Release note