-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Fix compile error under macos #9102
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
/hold |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #9101, ref #8835
Problem Summary:
Introduce by #9064
The signature of
je_mallctl
isBut we pass a
uint64_t *
foroldlenp
.'uint64_t' is 'unsigned long long ' while 'size_t' is 'unsigned long' under MacOS, that cause the following compile error
What is changed and how it works?
Change the type from
uint64_t
tosize_t
for 3rd param ofje_mallctl
Check List
Tests
Side effects
Documentation
Release note