Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storages: Trace memory allocation by thread #9064

Merged
merged 16 commits into from
May 22, 2024
Merged

Storages: Trace memory allocation by thread #9064

merged 16 commits into from
May 22, 2024

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented May 20, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8835

Problem Summary:

Every worker thread in various bg threads pools of TiFlash's storage module shall be recorded and aggregated, if jemalloc is supported.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
get ptrs
0532841 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fmt
933fe39 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
report
5b55898 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
a
f9ed27e 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels May 20, 2024
CalvinNeo and others added 8 commits May 20, 2024 17:27
@CalvinNeo
f
78136a7 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
make test work]
1d48a78 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
Merge branch 'master' into kvstore-malloc-tracer
94a9d0b
@CalvinNeo
manage
5d5b273 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
d
7e3003a 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix
4f94412 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
f
768c486 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
bg
5d2eda8 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo changed the title dnm Storages: Trace memory allocation by thread Storages: Trace memory allocation by thread May 21, 2024
@CalvinNeo
Copy link
Member Author

image

@CalvinNeo
Copy link
Member Author

/cc @JaySon-Huang @JinheLin @Lloyd-Pottiger

@CalvinNeo
f
b9df749 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
fix test
c76591a 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo
metric
61ae1e1 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 22, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 22, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label May 22, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JinheLin,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 22, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-22 05:32:55.203193637 +0000 UTC m=+2236128.960329209: ☑️ agreed by Lloyd-Pottiger.
  • 2024-05-22 05:57:02.34635101 +0000 UTC m=+2237576.103486584: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot merged commit 66a88e2 into pingcap:master May 22, 2024
5 checks passed
This was referenced May 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

@JinheLin JinheLin JinheLin approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support thread-wise memory alloc/dealloc monitor
3 participants
@CalvinNeo @JinheLin @Lloyd-Pottiger