api(ticdc): Not show the error info during query the changefeed when …

…state is stopped, finished and removed (#11641)

close #11642

cdc/api/v2/changefeed.go

@@ -284,7 +284,7 @@ func (h *OpenAPIV2) listChangeFeeds(c *gin.Context) {
 
 		// if the state is normal, we shall not return the error info
 		// because changefeed will is retrying. errors will confuse the users
-		if commonInfo.FeedState == model.StateNormal {
+		if !shouldShowRunningError(commonInfo.FeedState) {
 			commonInfo.RunningError = nil
 		}
 
@@ -1025,6 +1025,15 @@ func (h *OpenAPIV2) synced(c *gin.Context) {
 	})
 }
 
+func shouldShowRunningError(state model.FeedState) bool {
+	switch state {
+	case model.StateNormal, model.StateStopped, model.StateFinished, model.StateRemoved:
+		return false
+	default:
+		return true
+	}
+}
+
 func toAPIModel(
 	info *model.ChangeFeedInfo,
 	resolvedTs uint64,
@@ -1036,7 +1045,7 @@ func toAPIModel(
 
 	// if the state is normal, we shall not return the error info
 	// because changefeed will is retrying. errors will confuse the users
-	if info.State != model.StateNormal && info.Error != nil {
+	if info.Error != nil && shouldShowRunningError(info.State) {
 		runningError = &RunningError{
 			Addr:    info.Error.Addr,
 			Code:    info.Error.Code,

tests/integration_tests/changefeed_error/run.sh

@@ -118,7 +118,7 @@ function run() {
 	run_cdc_cli changefeed create --start-ts=0 --sink-uri="$SINK_URI" -c $changefeedid_3
 	ensure $MAX_RETRIES check_changefeed_state http://${UP_PD_HOST_1}:${UP_PD_PORT_1} ${changefeedid_3} "normal" "null" ""
 	run_cdc_cli changefeed pause -c $changefeedid_3
-	ensure $MAX_RETRIES check_changefeed_state http://${UP_PD_HOST_1}:${UP_PD_PORT_1} ${changefeedid_3} "stopped" "changefeed new redo manager injected error" ""
+	ensure $MAX_RETRIES check_changefeed_state http://${UP_PD_HOST_1}:${UP_PD_PORT_1} ${changefeedid_3} "stopped" "null" ""
 	run_cdc_cli changefeed resume -c $changefeedid_3
 	ensure $MAX_RETRIES check_changefeed_state http://${UP_PD_HOST_1}:${UP_PD_PORT_1} ${changefeedid_3} "normal" "null" ""
 	run_cdc_cli changefeed remove -c $changefeedid_3