-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api(ticdc): Not show the error info during query the changefeed when state is stopped, finished and removed #11641
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11641 +/- ##
================================================
- Coverage 55.2635% 55.2441% -0.0195%
================================================
Files 1001 1001
Lines 136162 136237 +75
================================================
+ Hits 75248 75263 +15
- Misses 55426 55485 +59
- Partials 5488 5489 +1 |
cdc/api/v2/changefeed.go
Outdated
@@ -284,7 +284,7 @@ func (h *OpenAPIV2) listChangeFeeds(c *gin.Context) { | |||
|
|||
// if the state is normal, we shall not return the error info | |||
// because changefeed will is retrying. errors will confuse the users | |||
if commonInfo.FeedState == model.StateNormal { | |||
if commonInfo.FeedState == model.StateNormal || commonInfo.FeedState == model.StateStopped || commonInfo.FeedState == model.StateFinished || commonInfo.FeedState == model.StateRemoved { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too complex here, exact it to a function, then use it in line 1039
/retest |
[LGTM Timeline notifier]Timeline:
|
/test cdc-integration-storage-test |
@hongyunyan: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/merge |
@hongyunyan: We have migrated to builtin 👉 Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, benmeadowcroft, hongyunyan, sdojjy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #11642
What is changed and how it works?
Make the previous error message not return when changefeed state is stopped / finished / removed, to avoid confused.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note