api(ticdc): Not show the error info during query the changefeed when state is stopped, finished and removed

[hongyunyan]

What problem does this PR solve?

Issue Number: close #11642

What is changed and how it works?

Make the previous error message not return when changefeed state is stopped / finished / removed, to avoid confused.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.2441%. Comparing base (8532fab) to head (3ac065a).
Report is 7 commits behind head on master.

Additional details and impacted files

Components	Coverage Δ
cdc	59.8317% <100.0000%> (-0.0336%)	⬇️
dm	50.0481% <ø> (-0.0164%)	⬇️
engine	53.2392% <ø> (+0.0139%)	⬆️

Flag	Coverage Δ
unit	55.2441% <100.0000%> (-0.0195%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11641        +/-   ##
================================================
- Coverage   55.2635%   55.2441%   -0.0195%     
================================================
  Files          1001       1001                
  Lines        136162     136237        +75     
================================================
+ Hits          75248      75263        +15     
- Misses        55426      55485        +59     
- Partials       5488       5489         +1     

[sdojjy]

too complex here, exact it to a function, then use it in line 1039

[hongyunyan]

/retest

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-10-15 10:33:56.377357925 +0000 UTC m=+353633.526267757: ☑️ agreed by asddongmen.
• 2024-10-15 14:53:18.519877695 +0000 UTC m=+369195.668787522: ☑️ agreed by sdojjy.

[hongyunyan]

/test cdc-integration-storage-test

[ti-chi-bot]

@hongyunyan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test cdc-integration-kafka-test
• /test cdc-integration-mysql-test
• /test cdc-integration-pulsar-test
• /test cdc-integration-storage-test
• /test dm-compatibility-test
• /test dm-integration-test
• /test engine-integration-test
• /test verify
• /test wip-pull-build
• /test wip-pull-check
• /test wip-pull-unit-test-cdc
• /test wip-pull-unit-test-dm
• /test wip-pull-unit-test-engine

Use /test all to run the following jobs that were automatically triggered:

• pingcap/tiflow/ghpr_verify
• pingcap/tiflow/pull_cdc_integration_kafka_test
• pingcap/tiflow/pull_cdc_integration_pulsar_test
• pingcap/tiflow/pull_cdc_integration_storage_test
• pingcap/tiflow/pull_cdc_integration_test
• pingcap/tiflow/pull_dm_compatibility_test
• pingcap/tiflow/pull_dm_integration_test
• pingcap/tiflow/pull_engine_integration_test

In response to this:

/test cdc-integration-storage-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hongyunyan]

/retest

[hongyunyan]

/merge

[ti-chi-bot]

@hongyunyan: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[hongyunyan]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, benmeadowcroft, hongyunyan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [asddongmen,hongyunyan,sdojjy]
• cdc/api/v2/OWNERS [benmeadowcroft]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment