Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker-count should has limit to set value #1716

Closed
Tammyxia opened this issue Apr 28, 2021 · 4 comments · Fixed by #4482
Closed

worker-count should has limit to set value #1716

Tammyxia opened this issue Apr 28, 2021 · 4 comments · Fixed by #4482
Assignees
@overvenus
Labels
area/ticdc Issues or PRs related to TiCDC. bug-from-internal-test Bugs found by internal testing. component/cli CLI component. severity/minor type/bug The issue is confirmed as a bug.

Comments

@Tammyxia
Copy link

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

  • Create changefeed --sink-uri='xxx/worker-count=0'
    image

  • Create changefeed --sink-uri='xxx/worker-count=1000000000000000'
    image

  1. What did you expect to see?
  • worker-count=0 is not allowed to set
  • What is the max value for worker-count? worker-count=1000000000000000 seems too large to allowed be to set.

  1. What did you see instead?
    Successfully to create changefeed with worker-count=0 or worker-count=1000000000000000

  2. Versions of the cluster

    • Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

      5.0.0-nightly

    • TiCDC version (execute cdc version):

      5.0.0-nightly
@Tammyxia Tammyxia added type/bug The issue is confirmed as a bug. severity/moderate bug-from-internal-test Bugs found by internal testing. labels Apr 28, 2021
@Tammyxia
Copy link
Author

/worker-count=-1 also allowed to create.

@Tammyxia
Copy link
Author

image
too large worker-count makes runtim oom.

@Rustin170506 Rustin170506 mentioned this issue Jun 28, 2021
Closed
3 tasks
@Rustin170506
Copy link
Member

/assign

@Rustin170506
Copy link
Member

/worker-count=-1 also allowed to create.

It will use the default value.

@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Dec 6, 2021
@overvenus overvenus assigned overvenus and unassigned Rustin170506 Jan 26, 2022
@overvenus overvenus mentioned this issue Jan 26, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jan 26, 2022
@overvenus
cmd,sink(ticdc): validate changefeed params and revise error message (#…
f917d36 
…4482)

close #1716, close #1718, close #1719, close #4472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@overvenus overvenus

Labels
area/ticdc Issues or PRs related to TiCDC. bug-from-internal-test Bugs found by internal testing. component/cli CLI component. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cmd,sink(ticdc): validate changefeed params and revise error message overvenus/ticdc
4 participants
@overvenus @Rustin170506 @AkiraXie @Tammyxia