Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd,sink(ticdc): validate changefeed params and revise error message #4482

Merged
merged 11 commits into from
Jan 26, 2022
Merged

cmd,sink(ticdc): validate changefeed params and revise error message #4482

merged 11 commits into from
Jan 26, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: close #1716 close #1718 close #1719 close #4472

What is changed and how it works?

Check List

Tests

  • Unit test

Release note 

Validate changefeed parameters on creation and revise error message

@overvenus
sink(ticdc): validate mysql sink params
458a43d 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
cmd,version(ticdc): validate sort-engine
85664e6 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
pkg/cmd(ticdc): revise pd connection error message
cf6f1a3 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added type/bugfix This PR fixes a bug. component/cli CLI component. labels Jan 26, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 26, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 26, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 26, 2022
Rustin170506
Rustin170506 approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

cdc/sink/mysql_params.go Outdated Show resolved Hide resolved
cdc/sink/mysql_params.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 26, 2022
@overvenus
address comments
dde4fbc 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
address comments
56a504a 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 56a504a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@overvenus
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8e6396d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 26, 2022
@overvenus
Copy link
Member Author

/run-leak-test

@overvenus
Copy link
Member Author

/run-kafka-integration-test

@overvenus
Copy link
Member Author

/run-verify
/run-kafka-integration-test
/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit f917d36 into pingcap:master Jan 26, 2022
@kennytm kennytm mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@zhaoxinyu zhaoxinyu Awaiting requested review from zhaoxinyu

Assignees
No one assigned
Labels
component/cli CLI component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
4 participants
@overvenus @ti-chi-bot @3AceShowHand @Rustin170506