Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sink write rows doesn't represent the real rows when sink is MQ #3431

Closed
sleepymole opened this issue Nov 12, 2021 · 1 comment · Fixed by #4192
Closed

Sink write rows doesn't represent the real rows when sink is MQ #3431

sleepymole opened this issue Nov 12, 2021 · 1 comment · Fixed by #4192
Assignees
@zhaoxinyu
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@sleepymole
Copy link
Contributor

What did you do?

image

When sink is MQ, txn_batch_size represents the count of messages instead of the count of rows.

What did you expect to see?

The metric is accurate when sink is MQ.

What did you see instead?

The metric is incorrect when sink is MQ.

Versions of the cluster

master
@sleepymole sleepymole added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. labels Nov 12, 2021
@zhaoxinyu zhaoxinyu mentioned this issue Nov 24, 2021
Merged
@overvenus
Copy link
Member

Fixed by #3609

This was referenced Dec 10, 2021
Merged
Merged
Merged
Merged
Merged
@3AceShowHand 3AceShowHand mentioned this issue Jan 4, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Jan 4, 2022
@3AceShowHand
metrics(cdc): fix mq sink write row count metrics. (#4192)
fc70dbd 
close #3431
This was referenced Jan 4, 2022
Merged
Merged
Merged
Closed
Closed
Merged
ti-chi-bot added a commit that referenced this issue Jan 4, 2022
@ti-chi-bot
metrics(cdc): fix mq sink write row count metrics. (#4192) (#4210)
e6c613b 
close #3431
@overvenus overvenus mentioned this issue Jan 13, 2022
Merged
14 tasks
This was referenced Jan 13, 2022
Merged
Merged
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this issue Jan 20, 2022
@3AceShowHand @zhaoxinyu
metrics(cdc): fix mq sink write row count metrics. (pingcap#4192)
6d8fef7 
close pingcap#3431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhaoxinyu zhaoxinyu

Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

metrics(cdc): fix mq sink write row count metrics. 3AceShowHand/tiflow
4 participants
@overvenus @zhaoxinyu @sleepymole @Tammyxia