-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics(cdc): fix mq sink write row count metrics. (#4192) #4206
metrics(cdc): fix mq sink write row count metrics. (#4192) #4206
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
1 similar comment
/run-all-tests |
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.0 #4206 +/- ##
================================================
Coverage ? 62.2610%
================================================
Files ? 161
Lines ? 16842
Branches ? 0
================================================
Hits ? 10486
Misses ? 5445
Partials ? 911 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 9adb97e
|
This is an automated cherry-pick of #4192
What problem does this PR solve?
Issue Number: close #3431
What is changed and how it works?
For Canal-JSON,
sink-write-rows-count
is not correctly recorded, this PR only fixes Canal-JSON at the moment.Maybe we should take further investigation into sink related metrics, and tries to unify them together.
Check List
Tests
Code changes
Side effects
Related changes
Release note