Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiCDC add a test to cover the invariant between MqMessageTypeResolved Event and other Events. #4128

Closed
3AceShowHand opened this issue Dec 29, 2021 · 0 comments · Fixed by #4129
Closed

TiCDC add a test to cover the invariant between MqMessageTypeResolved Event and other Events. #4128

3AceShowHand opened this issue Dec 29, 2021 · 0 comments · Fixed by #4129
Assignees
@3AceShowHand
Labels
area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.

Comments

@3AceShowHand
Copy link
Contributor

Is your feature request related to a problem?

TiCDC would send MqMessageTypeResolved messages to the MQ sink, with protocol such as open-protocol, craft, and canal-json.

We need to find a way to guarantee the semantic of the MqMessageTypeResolved message:

If the downstream MQ sink receive a MqMessageTypeResolved message with ts = a, it should be guaranteed that:

  • all received messages should have ts less than a
  • no more messages with ts less than a will be received by the downstream.

Describe the feature you'd like

We have kafka-consumer at the moment, investigating whether it can be used to solve the problem mentioned above.

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response
@3AceShowHand 3AceShowHand added the type/enhancement The issue or PR belongs to an enhancement. label Dec 29, 2021
@3AceShowHand 3AceShowHand self-assigned this Dec 29, 2021
@3AceShowHand 3AceShowHand mentioned this issue Dec 29, 2021
Merged
@3AceShowHand 3AceShowHand changed the title TiCDC add a test to cover the semantic of MqMessageTypeResolved Event. TiCDC add a test to cover the invariant between MqMessageTypeResolved Event and other Events. Jan 4, 2022
@amyangfei amyangfei added the area/ticdc Issues or PRs related to TiCDC. label Jan 6, 2022
ti-chi-bot pushed a commit that referenced this issue Jan 25, 2022
@3AceShowHand
consumer(ticdc): update the logic of consumer. (#4129)
43a1d78 
close #4128
This was referenced Jan 25, 2022
Merged
Closed
Closed
Closed
Merged
Merged
ti-chi-bot added a commit that referenced this issue Feb 21, 2022
@ti-chi-bot
consumer(ticdc): update the logic of consumer. (#4129) (#4465)
9b6e289 
close #4128
ti-chi-bot added a commit that referenced this issue Feb 24, 2022
@ti-chi-bot
consumer(ticdc): update the logic of consumer. (#4129) (#4470)
34e5660 
close #4128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3AceShowHand 3AceShowHand

Labels
area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

consumer(ticdc): update the logic of consumer. 3AceShowHand/tiflow
2 participants
@amyangfei @3AceShowHand